Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set state to 'closed' when CloseAsync() is called #3149

Merged
merged 6 commits into from Mar 14, 2023
Merged

Set state to 'closed' when CloseAsync() is called #3149

merged 6 commits into from Mar 14, 2023

Conversation

abhipsaMisra
Copy link
Member

No description provided.

drwill-ms
drwill-ms reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@drwill-ms drwill-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still encourage you to make a helper class that encapsulates the long and hard coded values 0/1, exposes a bool get/set via method.

@abhipsaMisra
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abhipsaMisra abhipsaMisra enabled auto-merge (squash) March 14, 2023 00:30
@abhipsaMisra abhipsaMisra merged commit 1dc5eef into main Mar 14, 2023
14 checks passed
@abhipsaMisra abhipsaMisra deleted the abmisr/fix branch March 14, 2023 00:39
abhipsaMisra added a commit that referenced this pull request Mar 14, 2023
@abhipsaMisra
Set state to 'closed' when CloseAsync() is called (#3149)
36b497a
@abhipsaMisra abhipsaMisra mentioned this pull request Mar 14, 2023
Merged
abhipsaMisra added a commit that referenced this pull request Mar 14, 2023
@abhipsaMisra
Set state to 'closed' when CloseAsync() is called (#3149) (#3160)
008b3fd
@abhipsaMisra abhipsaMisra mentioned this pull request Mar 14, 2023
Closed
This was referenced Apr 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwill-ms drwill-ms drwill-ms approved these changes

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@patilsnr patilsnr patilsnr approved these changes

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@brycewang-microsoft brycewang-microsoft Awaiting requested review from brycewang-microsoft brycewang-microsoft is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhipsaMisra @drwill-ms @timtay-microsoft @patilsnr