Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw IotHubClientException for file uploading with invalid correlation id #3159

Merged
merged 13 commits into from Mar 20, 2023
Merged

Throw IotHubClientException for file uploading with invalid correlation id #3159

merged 13 commits into from Mar 20, 2023

Conversation

brycewang-microsoft
Copy link
Contributor

@brycewang-microsoft brycewang-microsoft commented Mar 13, 2023 •
edited

Also:

  • rename "iothub/device/src/Exceptions/ExceptionHandlingHelper" to "ClientExceptionHandlingHelper"
  • rename "iothub/service/src/Exceptions/ExceptionHandlingHelper" to "ServiceExceptionHandlingHelper"
  • Add unit tests for "ClientExceptionHandlingHelper" class

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

drwill-ms
drwill-ms requested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@drwill-ms drwill-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment inline. We should parse the payload and make a proper exception out of it.

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brycewang-microsoft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drwill-ms drwill-ms merged commit b539bbe into previews/v2 Mar 20, 2023
1 check passed
@drwill-ms drwill-ms deleted the brycewang/http-exception branch March 20, 2023 18:35
@brycewang-microsoft brycewang-microsoft mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwill-ms drwill-ms drwill-ms approved these changes

@timtay-microsoft timtay-microsoft timtay-microsoft approved these changes

@patilsnr patilsnr patilsnr approved these changes

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra abhipsaMisra is a code owner

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brycewang-microsoft @drwill-ms @timtay-microsoft @patilsnr