Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TelemetryMessage should be able to take bytes and not serialize them #3242

Merged
merged 5 commits into from Apr 4, 2023
Merged

TelemetryMessage should be able to take bytes and not serialize them #3242

merged 5 commits into from Apr 4, 2023

Conversation

drwill-ms
Copy link
Contributor

No description provided.

@drwill-ms
Rename and cleanup ErrorDelegatingHandler (#3234)
ca2747e 
* Rename and cleanup ErrorDelegatingHandler

* Fix test failure and rename tests

* fatal exception types doesn't need to be a hashset

* Fix test

* Fix AMQP exception for scenario

* Remove unecessary statements from test

* Fix fault injection tests broken with gateway v2

* In person CR with Abhipsa

* Fix fault injection error handling over MQTT
@drwill-ms
TelemetryMessage should be able to take bytes and not serialize them
aa78f34
@drwill-ms
PR feedback
fce6add
@drwill-ms
merge
30229a3
@drwill-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

abhipsaMisra
abhipsaMisra approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drwill-ms drwill-ms merged commit c02749a into previews/v2 Apr 4, 2023
8 of 11 checks passed
@drwill-ms drwill-ms deleted the drwill/message-payload-bytes branch April 4, 2023 23:50
@brycewang-microsoft brycewang-microsoft mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhipsaMisra abhipsaMisra abhipsaMisra approved these changes

@patilsnr patilsnr patilsnr approved these changes

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft timtay-microsoft is a code owner

@andyk-ms andyk-ms Awaiting requested review from andyk-ms andyk-ms is a code owner

@brycewang-microsoft brycewang-microsoft Awaiting requested review from brycewang-microsoft brycewang-microsoft is a code owner

@tmahmood-microsoft tmahmood-microsoft Awaiting requested review from tmahmood-microsoft tmahmood-microsoft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drwill-ms @abhipsaMisra @patilsnr