Separate out semaphores for subscription and client open-close #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Apr 5, 2023
| @@ -137,18 +141,17 @@ await _internalRetryHandler | |||
| async () => | |||
| { | |||
| await VerifyIsOpenAsync(cancellationToken).ConfigureAwait(false); | |||
There was a problem hiding this comment.
I'll renew my dislike for the semaphore wait to evaluate _isOpen. I don't see what it buys us, and it costs each operation an extra semaphore get.
Did you have a future plan to refactor that?
There was a problem hiding this comment.
Yess, we'll get rid of the semaphores once we introduce the atomic variable for the state variable
drwill-ms
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.