Allow users to pass in HttpClient to use for file upload operations #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations` Also fix how the default http message handler is created for the various frameworks we target
timtay-microsoft
requested review from
drwill-ms,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
timtay-microsoft
changed the title
Co-authored-by: David R. Williamson <14119884+drwill-ms@users.noreply.github.com>
…zure/azure-iot-sdk-csharp into timtay/connectionLeaseTimeout3
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
Co-authored-by: David R. Williamson <14119884+drwill-ms@users.noreply.github.com>
…zure/azure-iot-sdk-csharp into timtay/connectionLeaseTimeout3
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
reviewed
Apr 21, 2023
drwill-ms
approved these changes
Apr 21, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't target any version of .NET core in our device SDK, there is no way for us to create an HttpClient that sets the connection lease timeout for the user by default. Instead, we will allow users to pass in an HttpClient that we will use. This allows .NET core users to construct an HTTP client with their desired connection lease timeout, and give it to the SDK to use.
For .NET standard, net472, and .NET 5+ cases, the SDK can set the connection lease timeout for the user by default.
On the service SDK side, .NET standard, net472, .NET 5+ and .NET core 2.1+ cases will create an HttpClient with the connection lease timeout set by default.