addresses supporting byte[] in direct methods and making TwinProperties able to be directly converted to json #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patilsnr
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft and
tmahmood-microsoft
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iothub/device/src/DirectMethod/EdgeModuleDirectMethodRequest.cs
Outdated
Show resolved
Hide resolved
rido-min
suggested changes
Jun 22, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rido-min
reviewed
Jun 28, 2023
iothub/device/src/DirectMethod/EdgeModuleDirectMethodRequest.cs
Outdated
Show resolved
Hide resolved
rido-min
approved these changes
Jun 28, 2023
|
/azp run |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
No commit pushedDate could be found for PR 3340 in repo Azure/azure-iot-sdk-csharp |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses supporting byte[] in direct methods and making
TwinPropertiesable to be directly converted to jsonAPI surface diff:
namespace Microsoft.Azure.Devices.Client { public class DirectMethodRequest { + public byte[] GetPayload() - public byte[] GetPayloadAsBytes() } public class DirectMethodResponse { + public byte[] Payload { get; set; } - public object Payload { get; set; } + public object PayloadAsObject { get; set; } } public class EdgeModuleDirectMethodRequest { + internal byte[] Payload { get; set; } - internal object Payload { get; set; } + internal object PayloadAsObject { get; set; } } } namespace Microsoft.Azure.Devices { public class DirectMethodClientResponse { + internal byte[] PayloadAsBytes { get; set; } } public class DirectMethodServiceRequest { + public byte[] Payload { get; set; } - public object Payload { get; set; } + public object PayloadAsObject { get; set; } } }