Limit unsafe code to NET451 #654
Conversation
There was a problem hiding this comment.
Thanks @prmathur-microsoft .
Is it possible to completely remove these files from ns1.3/ns2.0?
| unsafe class ScheduledOverlapped | ||
|
|
||
| #else | ||
| class ScheduledOverlapped |
There was a problem hiding this comment.
Do we need this class in anything but NET451?
Overlapped operations are always unsafe. Can't we just remove the file from ns13/ns20?
| } | ||
| [Fx.Tag.SecurityNote(Critical = "Provides a set of unsafe methods used to work with the WaitableTimer")] | ||
| [SecurityCritical] | ||
| static class TimerHelper | ||
| { | ||
| public static unsafe SafeWaitHandle CreateWaitableTimer() | ||
| public static SafeWaitHandle CreateWaitableTimer() |
There was a problem hiding this comment.
This function is using UnsafeNativeMethods so it must be marked as unsafe.
| @@ -672,7 +662,7 @@ public static unsafe SafeWaitHandle CreateWaitableTimer() | |||
| } | |||
| return handle; | |||
| } | |||
| public static unsafe long Set(SafeWaitHandle timer, long dueTime) | |||
| public static long Set(SafeWaitHandle timer, long dueTime) | |||
| unsafe class ScheduledOverlapped | ||
| #else | ||
| class ScheduledOverlapped |
There was a problem hiding this comment.
Same as above - class contains unsafe code. It should be marked as unsafe. It would be ideal if we can remove it from ns builds.
There was a problem hiding this comment.
I have limited the unsafe code to net451 and hence changing the class to unsafe only for net451.
There was a problem hiding this comment.
The nature of the class (performing IOCP / Overlapped I/O) is unsafe. If all unsafe references have been removed then the class should not be doing anything.
|
One unrelated file upload test failed. |
Checklist
masterbranch.Description of the changes
Reference/Link to the issue solved with this PR (if any)