refactor(iot-dev): Add more verbose logging around link credit in amqp links #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p links We didn't have any logs that would keep us aware of the current link credit on either our sender or receiver links, and this state has come into question in a recent customer issue
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
brycewang-microsoft,
drwill-ms and
jamdavi
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
jamdavi
reviewed
Dec 8, 2021
.../src/main/java/com/microsoft/azure/sdk/iot/device/transport/amqps/LoggingFlowController.java
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
jamdavi
approved these changes
Dec 14, 2021
andyk-ms
approved these changes
Dec 14, 2021
azabbasi
approved these changes
Dec 14, 2021
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have any logs that would keep us aware of the current link credit on either our sender or receiver links, and this state has come into question in a recent customer issue