feat(iot-dev): Fix file upload complete notification API #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completeFileUploadAsync does not behave asynchronously, so the name was a mistake. Deprecating that API and creating a new one without the Async suffix
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms,
prmathur-microsoft and
vinagesh
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
abhipsaMisra
approved these changes
Sep 11, 2020
|
Looks good. Should we patch the LTS ? |
vinagesh
approved these changes
Sep 11, 2020
No, because it is actually async in .NET This java function returns syncrhonously, so it should never have been post-fixed with "async" |
It isn't really a critical bug fix or a security fix, so I don't see a reason to |
When do we finally delete the deprecated functions? |
Never, probably |
This was referenced Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completeFileUploadAsync does not behave asynchronously, so the name was a mistake. Deprecating that API and creating a new one without the Async suffix
#910