Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get 400 response when creating device with id contains # #187

Closed
formulahendry opened this issue Dec 22, 2017 · 3 comments
Closed

Get 400 response when creating device with id contains # #187

formulahendry opened this issue Dec 22, 2017 · 3 comments
Assignees

Comments

@formulahendry
Copy link
Member

Context

  • npm version: azure-iothub@1.2.0

Description of the issue:

Get 400 response from SDK, when creating device with id contains #
image

Code sample exhibiting the issue:

https://github.com/Microsoft/vscode-azure-iot-toolkit/blob/bf406fbc0d7903b4b38b32097d5034b685b8aaff/src/deviceExplorer.ts#L80

@pierreca
Copy link
Contributor

Looks like it's just a matter of uri-encoding the device id in the registry class. that's a pretty easy fix. would you mind taking a stab at it and submitting a pull-request?

@pierreca
Copy link
Contributor

pierreca commented Feb 7, 2018

@formulahendry
fix was released on NPM today:
https://github.com/Azure/azure-iot-sdk-node/releases/tag/2018-2-7

@formulahendry
Copy link
Member Author

Thank you @pierreca !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants