Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Issue #416. Use typeof rather than instanceof Function. #421

Merged
merged 1 commit into from
Nov 10, 2018
Merged

(fix) Issue #416. Use typeof rather than instanceof Function. #421

merged 1 commit into from
Nov 10, 2018

Conversation

anthonyvercolano
Copy link
Contributor

instanceof Function was broken in the context of node-red

Changed the code to do typeof object === 'function'

@pierreca
Copy link
Contributor

nit: unnecessary parenthesis everywhere undermine readability.

pierreca
pierreca approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@pierreca pierreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthonyvercolano anthonyvercolano merged commit 7684185 into master Nov 10, 2018
@anthonyvercolano anthonyvercolano deleted the instance-node-red branch November 15, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierreca pierreca pierreca approved these changes

@kpajdzik kpajdzik Awaiting requested review from kpajdzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyvercolano @pierreca