chore: updating pnp samples to normalize dps variables #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var symmetricKey = process.env.PROVISIONING_SYMMETRIC_KEY; | ||
| var provisioningHost = process.env.IOTHUB_DEVICE_DPS_ENDPOINT; | ||
| var idScope = process.env.IOTHUB_DEVICE_DPS_ID_SCOPE; | ||
| var registrationId = process.env.IOTHUB_DEVICE_DPS_DEVICE_ID; |
There was a problem hiding this comment.
It seems unfortunate that we have a DPS_DEVICE_ID environment variable being assigned to a registrationId variable.
anthonyvercolano
approved these changes
Jul 31, 2020
| var provisioningHost = process.env.PROVISIONING_HOST; | ||
| var idScope = process.env.PROVISIONING_IDSCOPE; | ||
| var registrationId = process.env.PROVISIONING_REGISTRATION_ID; | ||
| var symmetricKey = process.env.PROVISIONING_SYMMETRIC_KEY; |
There was a problem hiding this comment.
You're not using the same environment variables as the simple_thermostat.js file.
There was a problem hiding this comment.
Oops, that's a missed copy paste.
olivakar
reviewed
Jul 31, 2020
| } | ||
|
|
||
| try { | ||
| let result = await provisioningClient.register(); |
There was a problem hiding this comment.
you need a switch here which if dps u do this otherwise we go normally to connect to hub with connection string..
| var idScope = process.env.PROVISIONING_IDSCOPE; | ||
| var registrationId = process.env.PROVISIONING_REGISTRATION_ID; | ||
| var symmetricKey = process.env.PROVISIONING_SYMMETRIC_KEY; | ||
|
|
There was a problem hiding this comment.
you also need the environmental variable for device connection string that is gonna be used when dps not available
| var idScope = process.env.PROVISIONING_IDSCOPE; | ||
| var registrationId = process.env.PROVISIONING_REGISTRATION_ID; | ||
| var symmetricKey = process.env.PROVISIONING_SYMMETRIC_KEY; | ||
| var provisioningHost = process.env.IOTHUB_DEVICE_DPS_ENDPOINT; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdocfolder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution