Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure-iot-provisioning-service): add capabilities option to EnrollmentGroup #924

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

vishnureddy17
Copy link
Member

Addresses issue #922. Added a test as well.

@vishnureddy17 vishnureddy17 marked this pull request as ready for review February 2, 2021 19:25
…lmentGroup

Added capabilities option to EnrollmentGroup, added test

fix #922
@@ -171,6 +201,9 @@ describe('Provisioning Service Client: CRUD operations', function () {
debug(err);
}
assert.isNull(err,'Should be no error from the create');
if (testConfiguration.enrollmentObject.capabilities && testConfiguration.enrollmentObject.capabilities.iotEdge) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& testConfiguration.enrollmentObject.capabilities.iotEdge [](start = 61, length = 59)

Should probably delete everything past the &&

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I changed my mind. Leave it exactly the way it is.


In reply to: 569003962 [](ancestors = 569003962)

Copy link
Contributor

@anthonyvercolano anthonyvercolano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vishnureddy17 vishnureddy17 merged commit f0a5e74 into Azure:master Feb 3, 2021
@vishnureddy17 vishnureddy17 deleted the fix_922 branch February 3, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants