Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to add utilities directory from WebLogic offers #24

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Updated to add utilities directory from WebLogic offers #24

merged 2 commits into from
Apr 5, 2022

Conversation

sanjaymantoor
Copy link
Contributor

Updated to add utilities directory from following WebLogic offers

  • arm-oraclelinux-wls-admin
  • arm-oraclelinux-wls-cluster
  • arm-oraclelinux-wls-dynamic-cluster

@ghost
Copy link

ghost commented Mar 17, 2022

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ sanjaymantoor sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@galiacheng
Copy link
Collaborator

galiacheng commented Mar 30, 2022

Hello @sanjaymantoor thanks for you PR, the changes look good. As this project is referred in Oracle offers and IBM offers. Those offer may refer to a specified version, so please update the pom version for your changes:

  • Increase version number in arm-assembly/src/main/resources/assemblies/arm-assembly.xml
  • Increase version number in arm-parent/pom.xml
    • Also upgrade the assembly version in <arm.assembly.version>1.0.4</arm.assembly.version>
  • Make sure you are using the right version in the weblogic vm offers.

I've tested your changes with test cases:

  • Has no utilities folder: the weblogic on aks offer
  • Has utilities folder: the weblogic on vm offers in your repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants