Automatic conversion of query/ingestion urls in ingest clients

[AsafMah]

Changes:

• Removed complex endpoint detection system (as per discussion)
• Automatic conversion of query/ingestion urls in ingest clients - adds or removes "ingest-"
• Changed terminology to "ingestion endpoint" and "query endpoint" where possible
• Deprecated un-needed ctors

[github-actions]

Unit Test Results

246 tests   - 1   241 ✔️  - 1   47s ⏱️ - 1m 59s
  20 suites ±0       5 💤 ±0 
  20 files   ±0       0 ❌ ±0 

Results for commit 5d05551. ± Comparison against base commit cf21875.

This pull request removes 5 and adds 4 tests. Note that renamed tests count towards both.

com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithWrongDmUri_Fail
com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithWrongEngineUri_Fail
com.microsoft.azure.kusto.ingest.QueuedIngestClientTest ‑ IngestFromFile_GivenIngestClientAndEngineEndpoint_ThrowsIngestionClientException
com.microsoft.azure.kusto.ingest.QueuedIngestClientTest ‑ IngestFromFile_GivenIngestClientAndEngineEndpoint_ThrowsIngestionServiceException
com.microsoft.azure.kusto.ingest.StreamingIngestClientTest ‑ IngestFromFile_GivenStreamingIngestClientAndDmEndpoint_ThrowsIngestionClientException

com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithDefaultCtor_WithIngestUri_Pass
com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithDefaultCtor_WithPrivateIngestUri_Pass
com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithDefaultCtor_WithPrivateQueryUri_Pass
com.microsoft.azure.kusto.ingest.ManagedStreamingIngestClientTest ‑ CreateManagedStreamingIngestClient_WithDefaultCtor_WithQueryUri_Pass

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Merging #268 (5d05551) into master (cf21875) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
- Coverage     54.42%   54.36%   -0.07%     
+ Complexity      575      565      -10     
============================================
  Files            95       95              
  Lines          3274     3232      -42     
  Branches        313      307       -6     
============================================
- Hits           1782     1757      -25     
+ Misses         1362     1353       -9     
+ Partials        130      122       -8     

Impacted Files	Coverage Δ
...ure/kusto/ingest/ManagedStreamingIngestClient.java	72.41% <81.81%> (+1.50%)	⬆️
...microsoft/azure/kusto/ingest/IngestClientBase.java	87.50% <85.71%> (+32.32%)	⬆️
...rosoft/azure/kusto/ingest/IngestClientFactory.java	66.66% <100.00%> (+6.66%)	⬆️
...oft/azure/kusto/ingest/QueuedIngestClientImpl.java	72.90% <100.00%> (-0.60%)	⬇️
...soft/azure/kusto/ingest/StreamingIngestClient.java	85.71% <100.00%> (+4.17%)	⬆️
.../microsoft/azure/kusto/ingest/ResourceManager.java	73.61% <0.00%> (-3.48%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ohadbitt]

Did you test with proxies ?
If you did add a test for that

[ohadbitt]

Seems OK

[ohadbitt]

you can just do replace first - no need contains and else if