Switch to jackson library from org.json #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmaya-panda1
changed the title
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
============================================
- Coverage 54.48% 54.11% -0.38%
- Complexity 565 575 +10
============================================
Files 95 96 +1
Lines 3232 3284 +52
Branches 307 340 +33
============================================
+ Hits 1761 1777 +16
- Misses 1349 1368 +19
- Partials 122 139 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tanmaya-panda1
requested review from
AsafMah,
ohadbitt,
yihezkel and
ag-ramachandran
ag-ramachandran
requested changes
Sep 9, 2022
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/exceptions/DataWebException.java
Outdated
Show resolved
Hide resolved
ag-ramachandran
requested changes
Sep 13, 2022
data/src/test/java/com/microsoft/azure/kusto/data/KustoDateTimeTest.java
Outdated
Show resolved
Hide resolved
data/src/test/java/com/microsoft/azure/kusto/data/KustoDateTimeTest.java
Show resolved
Hide resolved
quickstart/src/main/java/com/microsoft/azure/kusto/quickstart/SampleApp.java
Show resolved
Hide resolved
ohadbitt
requested changes
Sep 15, 2022
data/src/main/java/com/microsoft/azure/kusto/data/KustoOperationResult.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/KustoResultSetTable.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/KustoResultSetTable.java
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/KustoOperationResult.java
Outdated
Show resolved
Hide resolved
ohadbitt
reviewed
Sep 15, 2022
data/src/main/java/com/microsoft/azure/kusto/data/KustoResultSetTable.java
Show resolved
Hide resolved
…re/switchTojacksonForJson
…re-kusto-java into feature/switchTojacksonForJson
ohadbitt
approved these changes
Sep 21, 2022
ag-ramachandran
approved these changes
Sep 23, 2022
AsafMah
approved these changes
Oct 25, 2022
data/src/main/java/com/microsoft/azure/kusto/data/ClientRequestProperties.java
Outdated
Show resolved
Hide resolved
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@microsoft-github-policy-service agree |
AsafMah
pushed a commit
that referenced
this pull request
Dec 7, 2022
* switch to jackson for json * added formatter * fixed failing test cases * fixed testcases * ran formatter * added jackson-core to pom * fixed json string * fixed string conversion * bumped release version * bumped up release version * addressed Ram's review comments * formatter changes * refactored object mapper * addressed Ram's review comments * formatter changes * changes done as per Ohad's comments * added exception testcase for ResultSetTest * added bigdecimal for precision in decimal values * added comment for bigdecimal deserilaization * made options and parameters mandatory in tojson * fixed test case * accept cla * added formatter * commit for cla Co-authored-by: AsafMah <asafmahlev@microsoft.com> (cherry picked from commit c3bc043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
org.json:json is used for json parsing and reading capabilities
But org.json:json uses a non-free JSON license, which has already been banned by
Apache Software Foundation.
Debian
Hence org.json dependency is enforced as banned dependency in apache-nifi base pom.xml.
Considering this org.json needs to be removed and replaced with com.fasterxml.jackson
Future Release Comment
[Add description of your change, to include in the next release]
[Delete any or all irrelevant sections, e.g. if your change does not warrant a release comment at all]
Breaking Changes:
Features:
Fixes: