Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest from a ResultSet implementation #58

Merged
merged 12 commits into from
Dec 18, 2018
Merged

Ingest from a ResultSet implementation #58

merged 12 commits into from
Dec 18, 2018

Conversation

tamirkamara
Copy link
Contributor

@tamirkamara tamirkamara commented Dec 12, 2018 •
edited
Loading

This closes #2

@tamirkamara tamirkamara changed the base branch from master to dev December 12, 2018 07:56
danield137
danield137 previously approved these changes Dec 12, 2018
View reviewed changes
@tamirkamara
Copy link
Contributor Author

Please don't merge this (I'll do it myself)

limorl
limorl suggested changes Dec 13, 2018
View reviewed changes
Copy link

@limorl limorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are minor, except maybe for the last one.

ingest/src/main/java/com/microsoft/azure/kusto/ingest/IngestClientImpl.java Outdated Show resolved Hide resolved
ingest/src/main/java/com/microsoft/azure/kusto/ingest/IngestClientImpl.java Outdated Show resolved Hide resolved
ingest/src/main/java/com/microsoft/azure/kusto/ingest/IngestClientImpl.java Outdated Show resolved Hide resolved
ingest/src/test/java/com/microsoft/azure/kusto/ingest/IngestClientImplTest.java Show resolved Hide resolved
ingest/src/test/java/com/microsoft/azure/kusto/ingest/IngestClientImplTest.java Outdated Show resolved Hide resolved
limorl
limorl previously approved these changes Dec 16, 2018
View reviewed changes
Copy link

@limorl limorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the changes.

danield137
danield137 previously approved these changes Dec 16, 2018
View reviewed changes
@tamirkamara tamirkamara dismissed stale reviews from danield137 and limorl via 922e949 December 18, 2018 08:49
@tamirkamara tamirkamara mentioned this pull request Dec 18, 2018
Closed
@tamirkamara tamirkamara merged commit c2ffedf into dev Dec 18, 2018
@tamirkamara tamirkamara deleted the ingest-resultset1 branch December 18, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshetah toshetah toshetah approved these changes

@limorl limorl limorl left review comments

@danield137 danield137 danield137 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamirkamara @limorl @danield137 @toshetah