Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use arrow sub-crate and update dependencies #27

Merged
merged 1 commit into from
Aug 7, 2023
Merged

use arrow sub-crate and update dependencies #27

merged 1 commit into from
Aug 7, 2023

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Jul 16, 2023

This PR just updates a bunch of dependencies and reduces the impact of using the arrow feature by using only some sub-crates rather then full-fledged arrow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

Test Results

46 tests  ±0   46 ✔️ ±0   2m 41s ⏱️ - 1m 35s
  5 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 436c398. ± Comparison against base commit 8f8ee1f.

This pull request removes 26 and adds 26 tests. Note that renamed tests count towards both.
src/client.rs - client::KustoClient ‑ execute_command (line 259)
src/client.rs - client::KustoClient ‑ execute_query (line 176)
src/client.rs - client::KustoClient ‑ execute_query_to_struct (line 215)
src/client.rs - client::KustoClient ‑ execute_with_options (line 140)
src/client.rs - client::KustoClient ‑ new (line 84)
src/connection_string.rs - connection_string::ConnectionString ‑ build (line 1015)
src/connection_string.rs - connection_string::ConnectionString ‑ build_with_options (line 1029)
src/connection_string.rs - connection_string::ConnectionString ‑ from_raw_connection_string (line 500)
src/connection_string.rs - connection_string::ConnectionString ‑ with_application_auth (line 806)
src/connection_string.rs - connection_string::ConnectionString ‑ with_application_certificate_auth (line 839)
…
azure-kusto-data/src/client.rs - client::KustoClient ‑ execute_command (line 259)
azure-kusto-data/src/client.rs - client::KustoClient ‑ execute_query (line 176)
azure-kusto-data/src/client.rs - client::KustoClient ‑ execute_query_to_struct (line 215)
azure-kusto-data/src/client.rs - client::KustoClient ‑ execute_with_options (line 140)
azure-kusto-data/src/client.rs - client::KustoClient ‑ new (line 84)
azure-kusto-data/src/connection_string.rs - connection_string::ConnectionString ‑ build (line 1015)
azure-kusto-data/src/connection_string.rs - connection_string::ConnectionString ‑ build_with_options (line 1029)
azure-kusto-data/src/connection_string.rs - connection_string::ConnectionString ‑ from_raw_connection_string (line 500)
azure-kusto-data/src/connection_string.rs - connection_string::ConnectionString ‑ with_application_auth (line 806)
azure-kusto-data/src/connection_string.rs - connection_string::ConnectionString ‑ with_application_certificate_auth (line 839)
…

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #27 (fcb0e2d) into main (8f8ee1f) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head fcb0e2d differs from pull request most recent head 436c398. Consider uploading reports for the commit 436c398 to get more accurate results

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   68.55%   68.47%   -0.09%     
==========================================
  Files          14       14              
  Lines        1533     1532       -1     
==========================================
- Hits         1051     1049       -2     
- Misses        482      483       +1     
Impacted Files Coverage Δ
azure-kusto-data/src/arrow.rs 97.67% <ø> (ø)
azure-kusto-data/src/operations/query.rs 76.27% <ø> (ø)

... and 6 files with indirect coverage changes

@roeap roeap requested a review from AsafMah July 16, 2023 16:58
@roeap roeap temporarily deployed to sdke2e July 16, 2023 18:28 — with GitHub Actions Inactive
@roeap roeap changed the title update dependencies use arrow sub-crate and update dependencies Jul 17, 2023
@AsafMah AsafMah merged commit f26831d into main Aug 7, 2023
6 checks passed
@roeap roeap deleted the deps-1 branch August 10, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants