Skip to content

More passing tests (but more errors) #137

More passing tests (but more errors)

More passing tests (but more errors) #137

GitHub Actions / clippy succeeded Jan 2, 2024 in 1s

clippy

39 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 39
Note 0
Help 0

Versions

  • rustc 1.77.0-nightly (e51e98dde 2023-12-31)
  • cargo 1.77.0-nightly (ac6bbb332 2023-12-26)
  • clippy 0.1.77 (e51e98d 2023-12-31)

Annotations

Check warning on line 36 in azure-kusto-data/src/models/v2/errors.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> azure-kusto-data/src/models/v2/errors.rs:36:1
   |
36 | pub struct ErrorContext {
   | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 23 in azure-kusto-data/src/models/v2/errors.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> azure-kusto-data/src/models/v2/errors.rs:23:1
   |
23 | pub struct ErrorMessage {
   | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 6 in azure-kusto-data/src/models/v2/errors.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
 --> azure-kusto-data/src/models/v2/errors.rs:6:1
  |
6 | pub struct OneApiError {
  | ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 68 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
  --> azure-kusto-data/src/models/v2/mod.rs:68:1
   |
68 | pub type DataSet = Vec<Frame>;
   | ^^^^^^^^^^^^^^^^

Check warning on line 63 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> azure-kusto-data/src/models/v2/mod.rs:63:5
   |
63 |     pub fn into_result(self) -> Result<Vec<serde_json::Value>, OneApiError> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 46 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an enum

warning: missing documentation for an enum
  --> azure-kusto-data/src/models/v2/mod.rs:46:1
   |
46 | pub enum Row {
   | ^^^^^^^^^^^^

Check warning on line 2 in azure-kusto-data/src/models/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> azure-kusto-data/src/models/mod.rs:2:1
  |
2 | pub mod v2;
  | ^^^^^^^^^^

Check warning on line 1 in azure-kusto-data/src/models/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> azure-kusto-data/src/models/mod.rs:1:1
  |
1 | pub mod v1;
  | ^^^^^^^^^^

Check warning on line 78 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:78:5
   |
78 |     Dynamic(#[from] serde_json::Error),
   |     ^^^^^^^

Check warning on line 76 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:76:5
   |
76 |     Decimal(#[from] rust_decimal::Error),
   |     ^^^^^^^

Check warning on line 74 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:74:5
   |
74 |     Guid(#[from] uuid::Error),
   |     ^^^^

Check warning on line 72 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:72:5
   |
72 |     DateTime(#[from] time::error::Parse),
   |     ^^^^^^^^

Check warning on line 70 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:70:5
   |
70 |     Timespan(String),
   |     ^^^^^^^^

Check warning on line 68 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:68:5
   |
68 |     Bool(#[from] std::str::ParseBoolError),
   |     ^^^^

Check warning on line 66 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:66:5
   |
66 |     Float(#[from] std::num::ParseFloatError),
   |     ^^^^^

Check warning on line 64 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:64:5
   |
64 |     Int(#[from] std::num::ParseIntError),
   |     ^^^

Check warning on line 62 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a variant

warning: missing documentation for a variant
  --> azure-kusto-data/src/error.rs:62:5
   |
62 |     ValueNull(String),
   |     ^^^^^^^^^

Check warning on line 60 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an enum

warning: missing documentation for an enum
  --> azure-kusto-data/src/error.rs:60:1
   |
60 | pub enum ParseError {
   | ^^^^^^^^^^^^^^^^^^^

Check warning on line 16 in azure-kusto-data/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
  --> azure-kusto-data/src/lib.rs:16:1
   |
16 | pub mod models;
   | ^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> azure-kusto-data/src/lib.rs:1:9
   |
1  | #![warn(missing_docs)]
   |         ^^^^^^^^^^^^

Check warning on line 31 in azure-kusto-data/src/operations/v2.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> azure-kusto-data/src/operations/v2.rs:31:5
   |
31 |     return Ok(serde_json::from_slice(&buf)?);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
   |
31 -     return Ok(serde_json::from_slice(&buf)?);
31 +     Ok(serde_json::from_slice(&buf)?)
   |

Check warning on line 84 in azure-kusto-data/src/operations/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the method `send` doesn't need a mutable reference

warning: the method `send` doesn't need a mutable reference
  --> azure-kusto-data/src/operations/query.rs:84:19
   |
84 |             .send(&mut context, &mut request)
   |                   ^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed

Check warning on line 63 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large

warning: the `Err`-variant returned from this function is very large
  --> azure-kusto-data/src/models/v2/mod.rs:63:33
   |
63 |     pub fn into_result(self) -> Result<Vec<serde_json::Value>, OneApiError> {
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 328 bytes
   |
   = help: try reducing the size of `models::v2::errors::OneApiError`, for example by boxing large elements or replacing it with `Box<models::v2::errors::OneApiError>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

Check warning on line 53 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
  --> azure-kusto-data/src/models/v2/mod.rs:53:1
   |
53 | impl Into<Result<Vec<serde_json::Value>, OneApiError>> for Row {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
           https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
   = note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<models::v2::Row>`
   |
53 ~ impl From<Row> for Result<Vec<serde_json::Value>, OneApiError> {
54 ~     fn from(val: Row) -> Self {
55 ~         match val {
   |

Check warning on line 51 in azure-kusto-data/src/models/v2/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> azure-kusto-data/src/models/v2/mod.rs:46:1
   |
46 | / pub enum Row {
47 | |     /// A row in a table.
48 | |     Values(Vec<serde_json::Value>),
   | |     ------------------------------ the second-largest variant contains at least 0 bytes
49 | |     /// An error in a table.
50 | |     Error(OneApiError),
   | |     ------------------ the largest variant contains at least 328 bytes
51 | | }
   | |_^ the entire enum is at least 0 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
help: consider boxing the large fields to reduce the total size of the enum
   |
50 |     Error(Box<OneApiError>),
   |           ~~~~~~~~~~~~~~~~

Check warning on line 57 in azure-kusto-data/src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> azure-kusto-data/src/error.rs:9:1
   |
9  | / pub enum Error {
10 | |     /// Raised when failing to convert a kusto response to the expected type.
11 | |     #[error("Error converting Kusto response for {0}")]
12 | |     ConversionError(String),
...  |
36 | |     AzureError(#[from] azure_core::error::Error),
   | |     -------------------------------------------- the second-largest variant contains at least 72 bytes
...  |
56 | |     QueryApiError(OneApiError),
   | |     -------------------------- the largest variant contains at least 328 bytes
57 | | }
   | |_^ the entire enum is at least 328 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
56 |     QueryApiError(Box<OneApiError>),
   |                   ~~~~~~~~~~~~~~~~