C# SDK 2.0.0-preview2 stops working after 1 hour #9
Comments
|
@kspearrin We are unable to reproduce this particular issue. Can you give us a full repro of the issue in a small sample application? |
|
Are you using |
kmiecikt
added a commit
that referenced
this issue
Nov 16, 2018
The `SharedAccessSignatureTokenProvider` creates SAS tokens with 20-minute expiration time by default. To avoid re-creating tokens with each request, it uses memory cache with 1-minute expiration time. However, the memory cache uses sliding expiration window, so if the token is accessed every minute (or more frequently), the token is never removed from the cache and after 20 minutes it is rejected by the backend. The fix contains two changes: 1. The in-memory cache uses absolute expiration time instead of sliding expiration window. 2. The in-memory cache expiration time is set to SAS token expiration time minus 2 minutes. That should give us enough time to refresh the token and have some safety margin for potential clock skew in the cloud.
kmiecikt
added a commit
that referenced
this issue
Nov 16, 2018
The `SharedAccessSignatureTokenProvider` creates SAS tokens with 20-minute expiration time by default. To avoid re-creating tokens with each request, it uses memory cache with 1-minute expiration time. However, the memory cache uses sliding expiration window, so if the token is accessed every minute (or more frequently), the token is never removed from the cache and after 20 minutes it is rejected by the backend. The fix contains two changes: 1. The in-memory cache uses absolute expiration time instead of sliding expiration window. 2. The in-memory cache expiration time is set to SAS token expiration time minus 2 minutes. That should give us enough time to refresh the token and have some safety margin for potential clock skew in the cloud.
mpodwysocki
pushed a commit
that referenced
this issue
Nov 16, 2018
* Fixes issue #9: C# SDK stops working after 20 minutes The `SharedAccessSignatureTokenProvider` creates SAS tokens with 20-minute expiration time by default. To avoid re-creating tokens with each request, it uses memory cache with 1-minute expiration time. However, the memory cache uses sliding expiration window, so if the token is accessed every minute (or more frequently), the token is never removed from the cache and after 20 minutes it is rejected by the backend. The fix contains two changes: 1. The in-memory cache uses absolute expiration time instead of sliding expiration window. 2. The in-memory cache expiration time is set to SAS token expiration time minus 2 minutes. That should give us enough time to refresh the token and have some safety margin for potential clock skew in the cloud. * Increasing version number and updating release notes
|
@kspearrin closed as per #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am trying out the new 2.0.0-preview2 available on nuget in a ASP.NET Core 2.1 application on
netcoreapp2.1. This seems to work fine as a drop in replacement for 1.0.9 without any breaking changes.In my application,
NotificationHubClientis initialized as a properly of a singleton instance. I notice that after ~1 hour of the application running, anyNotificationHubClientfunctions that are invoked no longer work. My application does not throw any errors, but all activity to my Notification Hub ceases (confirmed by looking at metrics in the Azure portal) and I no longer get push notifications to my apps. If I restart the server (causing the singleton instance tonewagain) things again start working for ~1 hour and then stop again.Due to the nature of the consistent 1 hour lifetime of things working, I suspect that the
NotificationHubClientinstance is not renewing it's SAS token or something that has a 1 hour lifetime. To workaround this problem I now keep track of internal 30 minute timer where InewtheNotificationHubClientup again every 30 minutes. Doing this resolves the problem.The text was updated successfully, but these errors were encountered: