User Story 7571861: Java SDK changes for supporting send by userId #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstr
approved these changes
Jul 25, 2020
There was a problem hiding this comment.
These changes look super clean - thank you. I'm approving even with one minor comment.
Am I right about the Thread.sleep calls being scattered throughout the tests being there because the synchronous versions of methods aren't actually waiting for the operation to complete? If so, we should file a follow up item to go add .block(/*some appropriate timeout*/) to all of the similar methods. We would probably fix a lot of bugs for customers, and speed the tests up a lot doing so.
NotificationHubs/test/com/windowsazure/messaging/e2e/InstallationCrudsE2E.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Installation.java with add UserId property.
Updated NamespaceManager.java with new api version.
Updated tests.