Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java SDK X-WNS-Type inference logic doesn't handle node with attributes #58

Merged
merged 4 commits into from Aug 10, 2020
Merged

Java SDK X-WNS-Type inference logic doesn't handle node with attributes #58

merged 4 commits into from Aug 10, 2020

Conversation

itoys
Copy link
Contributor

@itoys itoys commented Aug 10, 2020

Fixes #51

@itoys itoys requested a review from marstr August 10, 2020 13:30
marstr
marstr approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@marstr marstr merged commit e3c8b0d into master Aug 10, 2020
@marstr marstr deleted the attr-wns-notification branch August 10, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't send UWP notification when toast tag with parameters
2 participants
@itoys @marstr