Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream dependency go-ieproxy requires CGO #31

Open
vangent opened this issue Apr 11, 2022 · 5 comments
Open

Upstream dependency go-ieproxy requires CGO #31

vangent opened this issue Apr 11, 2022 · 5 comments

Comments

@vangent
Copy link

vangent commented Apr 11, 2022

I have a project that depends on azure-pipeline-go, and a user has reported that it no longer compiles unless CGO compilation is enabled. This is new in the 0.0.2 and 0.0.3 version of go-ieproxy.

google/go-cloud#3114 is the bug report. Basically, compilation fails unless CGO_ENABLED=1 (Go defaults it to 1 in some scenarios, but you can always disable it).

@caarlos0
Copy link

Hey, thanks for opening it here @vangent

an idea here would be to not use ieproxy by default... users could still add it to their clients should they see it fit...

If y'all think that's acceptable, I can work on a PR for it.

@vangent
Copy link
Author

vangent commented Apr 14, 2022

Anything to not make CGO required by default would be great.

@gildas
Copy link

gildas commented Apr 29, 2022

ieporxy is now on 0.0.6 and I use azure-storage-blob-go.
After updating the packages in my go.mod, my project cannot compile anymore:

github.com/mattn/go-ieproxy
# github.com/mattn/go-ieproxy
../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.6/ieproxy.go:36:9: undefined: getConf
../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.6/ieproxy.go:41:9: undefined: reloadConf
../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.6/ieproxy.go:48:2: undefined: overrideEnvWithStaticProxy
../../../go/pkg/mod/github.com/mattn/go-ieproxy@v0.0.6/ieproxy.go:53:13: psc.findProxyForURL undefined (type *ProxyScriptConf has no field or method findProxyForURL, but does have FindProxyForURL)

@caarlos0
Copy link

One important thing to notice here: for now, this package specifies to depend on github.com/mattn/go-ieproxy v0.0.1, which does not have this issue.

Bottom line is: do not update go-ieproxy if you don't need to

@hairyhenderson
Copy link

Now that mattn/go-ieproxy#34 is fixed and go-ieproxy v0.0.8+ has support for not using CGO, perhaps the upstream dependency could be upgraded again, and this issue could be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants