Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetCore conversion for core modules #3746

Closed
13 of 16 tasks
markcowl opened this issue Apr 10, 2017 · 5 comments
Closed
13 of 16 tasks

NetCore conversion for core modules #3746

markcowl opened this issue Apr 10, 2017 · 5 comments

Comments

@markcowl
Copy link
Member

markcowl commented Apr 10, 2017

Description

Move core set of modules to build side-by-side in .Net Core and .Net Desktop. Core modules include:

  • Profile
  • Resource Manager
  • Storage Management (not data plane)
  • Websites
  • Compute
  • Network
  • Sql
  • Storage Data
  • KeyVault
  • Batch
  • Automation

The work should begin with updating the psm1 module definition to allow loading necessary DLLs:. A sample of additional assembly loading code is here: https://github.com/markcowl/azure-powershell-pr/blob/pscore20160816/src/ResourceManager/Profile/Microsoft.Azure.Commands.Profile/Account/AddAzureRmAccount.cs#L183 along wit source for working modules for profile and resource manager.

PowerShell Core source is here: https://github.com/powershell/powershell

Downloads are included on the README. We will need to discuss which particular version to target.

Some steps include:

  • Determine the core assemblies in powershell for netcore - some assmblies will be loaded in the AppDomain for you, including Newtonsoft.Json, System.Runtime.Serialization.Json (used by ADAL).
  • Change module projects to use VS2017 and build side-by-side with desktop modules
  • Run tests manually for first versions
  • Target test core projects to run in netcoreapp 1.1
  • Set up Jenkins, Travis, or AppVeyor builds for net core powershell tests, including signing builds
@janegilring
Copy link

Could you share the long term plan for the side by side strategy? For example, will the .Net Desktop based modules be deprecated when PS Core is released and the AzureRM.NetCore modules has feature parity with the AzureRM modules?

@markcowl
Copy link
Member Author

  • Update xunit tests for runnign in core when new PowerShell runtime modules available
  • Create tools and docs for adding NetCore infrastructure for new modules
  • Create schedule and file issues for remaining legacy modules into NetCore

@cormacpayne
Copy link
Member

AzureRM.Netcore 0.10.0 has been released and can be found here: https://github.com/Azure/azure-powershell/releases/tag/v0.10.0-nc-February2018

@MiYanni
Copy link
Contributor

MiYanni commented Mar 12, 2018

Automation covered here: #5718

@markcowl markcowl modified the milestones: 2018-03-09, 2018-03-23 Mar 14, 2018
@markcowl markcowl modified the milestones: 2018-03-23, 2018-04-06 Mar 26, 2018
@MiYanni
Copy link
Contributor

MiYanni commented Mar 27, 2018

The rest covered here: #5782

@MiYanni MiYanni closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants