Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTime issue restoring deleted webapp #16308

Merged
merged 2 commits into from Apr 2, 2022
Merged

Conversation

mbentancour
Copy link
Contributor

Fixes issue that prevents restoring deleted WebApps if the host running the script uses a locale with a different date format than en-US.

Description

Set en-US as locale when parsing the DeletedTimeStamp.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Fixes [issue](Azure#13245) that prevents restoring deleted WebApps if the host running the script uses a locale with a different date format than en-US.
Include changelog for Restore-AzDeletedWebApp DateTime fix
@ghost ghost added the customer-reported label Nov 1, 2021
@ghost
Copy link

ghost commented Nov 1, 2021

Thank you for your contribution mbentancour! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Nov 1, 2021

CLA assistant check
All CLA requirements met.

@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2021

Thanks for the contribution! 😁
@Kotasudhakarreddy Hi Kota, would you mind to review this PR?

@isra-fel isra-fel self-assigned this Nov 4, 2021
@mbentancour
Copy link
Contributor Author

@isra-fel @Kotasudhakarreddy Let me know if you need any information or clarification from my side.

@isra-fel isra-fel added Service Attention This issue is responsible by Azure service team. App Services aka WebSites labels Dec 2, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we couldn't get a review from service team and yet the code looks good to me. I'll go ahead a merge it.

@isra-fel isra-fel merged commit 00a2e50 into Azure:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services aka WebSites customer-reported needs-review Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebApp:Restore-AZdeletedwebapp Powershell cmdlet only works locally if date format is MM/DD/YYYY.
3 participants