Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppServices]: Fix #16646 : Marked New-AzWebAppContainerPSSession as obsolete #17303

Merged
merged 4 commits into from
Apr 12, 2022
Merged

[AppServices]: Fix #16646 : Marked New-AzWebAppContainerPSSession as obsolete #17303

merged 4 commits into from
Apr 12, 2022

Conversation

Kotasudhakarreddy
Copy link
Contributor

#16646

Description

We are no longer recommending customers to use the Win-RM capability as we added a Web Console in the portal and in the advanced Web Console in the “Advanced Tools” section of the portal which is better and more secure option. We are planning on stop supporting the Win-RM capability in the future.

For more information on the Web Console:
https://docs.microsoft.com/en-us/azure/app-service/configure-custom-container?pivots=container-windows#from-the-kudu-console

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

…nse when requested the WebApps under subscreption
…he response when requested the WebApps under subscreption"

This reverts commit 96a4d28.
@Kotasudhakarreddy Kotasudhakarreddy changed the title [AppServices]: Fix #16646 : Marked New-AzWebAppContainerPSSession as obsolete [AppServices]: Fix #16646 : Marked New-AzWebAppContainerPSSession as obsolete Mar 2, 2022
@BethanyZhou
Copy link
Contributor

Hi @Kotasudhakarreddy , could please provide more information about this deprecation to customer?

@Kotasudhakarreddy
Copy link
Contributor Author

Hi @Kotasudhakarreddy , could please provide more information about this deprecation to customer?

@BethanyZhou - Deprecation happens in the next Breaking change release. We don't have exact deprecateByVersion number or changeInEfectByDate currently. If you have an idea of next breaking change release please let me know. I can update more details to the customer.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Mar 3, 2022

Do you have a page to demonstrate this deprecation. We can use GenericBreakingChange to provide more information.

image

@Kotasudhakarreddy
Copy link
Contributor Author

Do you have a page to demonstrate this deprecation. We can use GenericBreakingChange to provide more information.

image

@panchagnula do we have any such page to demonstrate the deprecation other than the GitHub link.

@panchagnula
Copy link
Contributor

Do you have a page to demonstrate this deprecation. We can use GenericBreakingChange to provide more information.
image

@panchagnula do we have any such page to demonstrate the deprecation other than the GitHub link.

@jvano is there any public documentation for deprecation news?

@Kotasudhakarreddy
Copy link
Contributor Author

Do you have a page to demonstrate this deprecation. We can use GenericBreakingChange to provide more information.
image

@panchagnula do we have any such page to demonstrate the deprecation other than the GitHub link.

@jvano is there any public documentation for deprecation news?

@jvano any such public documentation for deprecation news?

@jvano
Copy link

jvano commented Mar 30, 2022

@apwestgarth, @Kotasudhakarreddy has some questions about the deprecation of the Win-RM feature for Windows Containers on App Service. Can you help getting his questions answered? The questions are around public notifications and documentation about this change.

@BethanyZhou
Copy link
Contributor

Sorry, let me clarify. Public notifications is unnecessary. Just want to let customer know what happens to this cmdlet and what should be done from customer side in next step. a public documentation would help customer know their situation.

@apwestgarth
Copy link
Member

Hi @BethanyZhou and @Kotasudhakarreddy we notified customers in September 2020 that the feature would be deprecated as it was removed from the preview functionality before we GA'd Windows Container support on Azure App Service. The ability to connect to a Windows Container via Win-RM was officially retired on 12th December 2020. Docs have long since been updated to remove mention of Win-RM connect.

This item is to formally remove the functionality from PowerShell.

For customers wishing to connect to their windows container they can use the following documentation link - https://docs.microsoft.com/azure/app-service/configure-custom-container?pivots=container-windows#connect-to-the-container or if you prefer a shortlink please use https://aka.ms/appsvcconnecttowincontainer

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The cmdlet and related code should be removed in the next month.

@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit fd6cb17 into Azure:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants