-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update New-AzContainerGroup Example6 #17515
Update New-AzContainerGroup Example6 #17515
Conversation
@@ -122,7 +123,7 @@ Location Name Zone ResourceGroupName | |||
eastus test-cg test-rg | |||
``` | |||
|
|||
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. | |||
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. For the volume property, AzureFile and GitRepo are recommanded. The EmptyDir property isn't supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. For the volume property, AzureFile and GitRepo are recommanded. The EmptyDir property isn't supported. | |
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. |
recommanded -> recommended
We support mounting Azure File share as a volume or specifying git repository as volume directory. The empty directory volume and secret volume are not supported yet.
Please add this statement in the docs of New-AzContainerGroupVolumeObject
@@ -20,7 +20,7 @@ New-AzContainerGroupVolumeObject -Name <String> [-AzureFileReadOnly] [-AzureFile | |||
``` | |||
|
|||
## DESCRIPTION | |||
Create a in-memory object for Volume | |||
Create a in-memory object for Volume. Currently, we support mounting Azure File share as a volume or specifying git repository as volume directory. The empty directory volume and secret volume are not supported yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitating to do this job. The description is auto-generated, I'm afraid that this change will be overridden in next change. Is there any way to customize description of cmdlets? @dolauli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cmdlet is a custom cmdlet. So we could customize the description in https://github.com/CaptainFanZzz/azure-powershell/blob/update-New-AzContainerGroup/src/ContainerInstance/custom/New-AzContainerGroupVolumeObject.ps1#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about New-AzContainerGroup? It's a customized cmdlet after generated . Can we use the same way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dolauli .
As @jaltin mentioned, could you create a separate PR for this issue? @CaptainFanZzz |
Okay |
59c5010
to
bf46747
Compare
bf46747
to
0f0f44f
Compare
@@ -122,7 +123,7 @@ Location Name Zone ResourceGroupName | |||
eastus test-cg test-rg | |||
``` | |||
|
|||
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. | |||
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. For the volume property, AzureFile and GitRepo are recommended. The EmptyDir property isn't supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. For the volume property, AzureFile and GitRepo are recommended. The EmptyDir property isn't supported. | |
This commands creates a container group with a container instance, whose image is a custom image from a custom container image registry. |
Remove unrelated description for this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Update New-AzContainerGroup Example6
Generation branch #17552
Fix for #17123
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added