Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources] fix redundant quotes in list pagination #17705

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

VeryEarly
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly changed the title fix redundant quotes in list pagination [Resources] fix redundant quotes in list pagination Apr 2, 2022
@VeryEarly VeryEarly linked an issue Apr 2, 2022 that may be closed by this pull request
@isra-fel
Copy link
Member

isra-fel commented Apr 2, 2022

Hi @VeryEarly , I would expect the test cases for both the handwritten cmdlets and generated ones to run (or at least the generated ones), but from the CI log it seemed none tests were run. Can you check what is wrong?
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1478228&view=logs&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=478d3a05-a1a2-5ee2-6dbe-5e69ce2a5ac6

@VeryEarly
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor Author

Hi @VeryEarly , I would expect the test cases for both the handwritten cmdlets and generated ones to run (or at least the generated ones), but from the CI log it seemed none tests were run. Can you check what is wrong? https://dev.azure.com/azure-sdk/public/_build/results?buildId=1478228&view=logs&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=478d3a05-a1a2-5ee2-6dbe-5e69ce2a5ac6

test for handcraft cmdlets are skipped intentionally, and tests for MSGraph are live only I think that is the reason no test cases were executed.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 63cfc1b into Azure:generation Apr 15, 2022
@VeryEarly VeryEarly deleted the yabo/msgraph branch April 19, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-AzADUser -Search fails on pagination
2 participants