-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web PubSub] Update to API version 2022-08-01-preview #20071
Conversation
@Nickcandy please help review |
@BethanyZhou Hi Beisi, it looks good to me |
.Link | ||
https://learn.microsoft.com/powershell/module/az./new-AzWebPubSubEventHubEndpointObject | ||
#> | ||
function New-AzWebPubSubEventHubEndpointObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding object cmdlet is supported by autorest, see details from https://github.com/Azure/autorest.powershell/blob/main/docs/directives.md#polymorphism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cmdlets generated by autorest is New-AzEventHubEndpointObject
(without WebPubSub prefix). Confirmed with @dolauli that we cannot customize the behaviour. So I have to implement it myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It surprised me. the generated cmdlets don't include prefix.
@Y-Sindo Hi there, there are several mistakes when I migrate SignalR to Main branch. As you can see in log : https://dev.azure.com/azclitools/public/_build/results?buildId=16993&view=logs&j=b9afb22f-0837-5d02-bc24-6c30aee08bcf&t=990f6f37-4a21-5927-092a-220f38a460e9 |
Description
Updated to API version 2022-08-01-preview
Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.