Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web PubSub] Update to API version 2022-08-01-preview #20071

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Nov 9, 2022

Description

Updated to API version 2022-08-01-preview

  • Added support for custom domain. Added new cmdlets New-AzWebPubSubCustomCertificate, Get-AzWebPubSubCustomCertificate, Remove-AzWebPubSubCustomCertificate, New-AzWebPubSubCustomDomain, Get-AzWebPubSubCustomDomain, Remove-AzWebPubSubCustomDomain.
  • Added support for event listeners in hub settings. Added new cmdlets New-AzWebPubSubEventHubEndpointObject, New-AzWebPubSubEventNameFilterObject.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@Y-Sindo Y-Sindo marked this pull request as ready for review November 9, 2022 13:13
@Y-Sindo Y-Sindo marked this pull request as draft November 9, 2022 13:21
@Y-Sindo Y-Sindo marked this pull request as ready for review November 9, 2022 13:27
@BethanyZhou
Copy link
Contributor

@Nickcandy please help review

@Nickcandy
Copy link
Contributor

@BethanyZhou Hi Beisi, it looks good to me

.Link
https://learn.microsoft.com/powershell/module/az./new-AzWebPubSubEventHubEndpointObject
#>
function New-AzWebPubSubEventHubEndpointObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding object cmdlet is supported by autorest, see details from https://github.com/Azure/autorest.powershell/blob/main/docs/directives.md#polymorphism

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmdlets generated by autorest is New-AzEventHubEndpointObject (without WebPubSub prefix). Confirmed with @dolauli that we cannot customize the behaviour. So I have to implement it myself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It surprised me. the generated cmdlets don't include prefix.

@Nickcandy Nickcandy merged commit 6a846eb into Azure:generation Nov 15, 2022
@Y-Sindo Y-Sindo deleted the 0801preview branch November 15, 2022 10:11
@Nickcandy
Copy link
Contributor

@Y-Sindo Hi there, there are several mistakes when I migrate SignalR to Main branch. As you can see in log : https://dev.azure.com/azclitools/public/_build/results?buildId=16993&view=logs&j=b9afb22f-0837-5d02-bc24-6c30aee08bcf&t=990f6f37-4a21-5927-092a-220f38a460e9
Please correct these error as soon as possible so that we can release ur change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants