Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peering] Create peering 2022 10 01 stable #20775

Closed
wants to merge 2 commits into from

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented Jan 30, 2023

Description

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1301
Swagger: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/peering/resource-manager/Microsoft.Peering/stable/2022-10-01

Merge to main: #20776

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@lijinpei2008
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel self-assigned this Jan 31, 2023
src/Peering/examples/New-AzPeering.md Outdated Show resolved Hide resolved
src/Peering/examples/New-AzPeering.md Outdated Show resolved Hide resolved
src/Peering/examples/Remove-AzPeeringServicePrefix.md Outdated Show resolved Hide resolved
@BethanyZhou
Copy link
Contributor

When we are planning to release new Peering?

@lijinpei2008
Copy link
Contributor Author

lijinpei2008 commented Feb 1, 2023

When we are planning to release new Peering?

02/06 release.
The handwritten code is already overwritten, we just need to merge this change into main.

@BethanyZhou BethanyZhou added this to the February 2023 (2023-02-07) milestone Feb 1, 2023
@lijinpei2008
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Feb 2, 2023

This doesn't HAVE to be merged before Feb release so I'm going to clear the release setting.

@isra-fel isra-fel removed this from the February 2023 (2023-02-07) milestone Feb 2, 2023
@lijinpei2008 lijinpei2008 deleted the feature/peering-2022-10-01-stable branch February 2, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants