Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Az Predictor version with new telemetry property name #21615

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

kceiw
Copy link
Contributor

@kceiw kceiw commented Apr 20, 2023

Description

Previously we improve how we detect what we collect in the telemetry. There was an improvement that wasn't released. In this PR, I updated the version for a new release, added a few test cases, and changed the telemetry property names. Instead of coming up with new words, I append the number to the property names.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Apr 20, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

dcaro
dcaro previously approved these changes Apr 20, 2023
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @isra-fel can you have a look at it?

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@isra-fel isra-fel merged commit f9b1289 into Azure:main Apr 24, 2023
msJinLei added a commit that referenced this pull request May 5, 2023
* Get-AzVM NextLink parameter set removal breaking change warning (#21444)

* breakingchange message

* ps

* Fix Assignment/Definition typo in Output (#21442)

See below result from running this locally:

PS C:\> $newDefinition = New-AzCosmosDBSqlRoleDefinition `
>> -ResourceGroupName $resourceGroupName `
>> -AccountName $accountName `
>> -RoleName "Quality Management Service CosmosDB Contributor" `
>> -AssignableScope "/dbs/$cosmosDatabaseName" `
>> -DataAction $builtInCosmosContributorRole.Permissions.dataActions
PS C:\> $newDefinition.GetType()

IsPublic IsSerial Name                                     BaseType
-------- -------- ----                                     --------
True     False    PSSqlRoleDefinitionGetResults            System.Object

* [AppService]: fix #21399 - [New-AzWebApp] -Tag parameter not available in all ParameterSets (#21447)

* Update with the latest test coverage data (#21441)

* [AKS] support parameter EnableOidcIssuer (#21423)

* [AKS] support parameter EnableOidcIssuer

* remove unnecessary test case part

* Update the breaking change warning to show which aliases will be removed (#21446)

* msg and changelog

* vmss

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* [AKS] support parameter OutboundType (#21457)

* Livetest (#21460)

* Limit container app live test running on latest ps version due to quota (15) set in one single subscription

* add test for connectedk8s

* revise livetest

* revise livetest

* Update TestLiveScenarios.ps1

---------

Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>

* remove obsolete deprication version attributes (#21474)

Co-authored-by: Aaron Zhang <aaron@Aarons-MacBook-Pro.local>

* Get-AzVM NextLink parameter removal breaking change message changelog update (#21483)

* breakingchange message

* ps

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Azure core upgrade from 1.28.0 to 1.30.0 (#21481)

* Update azure core

* Update ChangeLog of Modules depending on Azure.Core

* Missing assemblings

* {AzureWebApp} update the description of AzureStoragePath parameter (#21491)

* {AzureWebApp} update the description of AzureStoragePath parameter

Update the description of `-AzureStoragePath` parameter to include `New-AzWebAppAzureStoragePath` instead of `New-AzureRmWebAppAzureStoragePath`

Docs link:
https://learn.microsoft.com/en-us/powershell/module/az.websites/set-azwebappslot?view=azps-9.6.0
https://learn.microsoft.com/en-us/powershell/module/az.websites/set-azwebapp?view=azps-9.6.0

Fixes #21484

* Update Set-AzWebAppSlot.md

* Upadte NewtonSoft.Json to 13.0.2 (#21479)

* {AzureCompute} Include the ProvisioningState value in Get-AzVMRunCommand output (#21490)

* {AzureCompute} Include the ProvisioningState value in Get-AzVMRunCommand output

fixes #21473

ProvisioningState is empty in Get-AzVMRunCommand output. GET VM Run command REST API does return ProvisioningState correctly.

See the response returned:

```
Name                : navbaRunCommand
Location            : SouthIndia
Id                  : /subscriptions/XXXXXXX/resourceGroups/navbavmdel/providers/Microsoft.C
                      ompute/virtualMachines/navbavmdel/runCommands/navbaRunCommand
Type                : Microsoft.Compute/virtualMachines/runCommands
Tags                : {[Reason, Repro], [CreatedDate, 4/11/2023 4:07:00 AM], [CreatedBy, NA], [OwningTeam, NA]}
Source              : Microsoft.Azure.Management.Compute.Models.VirtualMachineRunCommandScriptSource
Parameters          : {}
ProtectedParameters : {}
AsyncExecution      : False
RunAsUser           :
RunAsPassword       :
TimeoutInSeconds    : 0
OutputBlobUri       :
ErrorBlobUri        :
ProvisioningState   :
InstanceView        :
```

This PR includes the fix for this and includes the ProvisioningState value in Get-AzVMRunCommand output

* Update PSVirtualMachineRunCommand.cs

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Update RunVersionController.ps1 (#21186)

* Fix the issue of dll conflict between Az.Aks and Pester (#21502)

* Resolve CVEs vulnerabilities in build pipeline (#21492)

* Resolve CVEs

* Update Compute.csproj

* Update DataFactoryV2.csproj

* Update Synapse.csproj

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* revise livetest for connectedkubernetes (#21497)

* revise live test

* revise code

* Migrate Aks from generation to main (#21509)

* Move Aks to main

* update changelog and suppress signature issues

---------

Co-authored-by: YanaXu <sheshouxy@gmail.com>

* Only when the live test is triggered by scheduled run, the result data will be saved to Kusto (#21508)

* Update the document Debugging-StaticAnalysis-Errors.md (#21480)

* Update the document Debugging-StaticAnalysis-Errors.md

* Update the document Debugging-StaticAnalysis-Errors.md

* Update Debugging-StaticAnalysis-Errors.md

* Update Debugging-StaticAnalysis-Errors.md

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Update Azure.core from 1.30.0 to 1.31.0 (#21506)

* Update azure core to 1.31.0

* Upgraded Microsoft.PowerShell.SDK to 7.0.13 (#21515)

* Update IsCustom property on example role defintion (#21514)

* Update IsCustom property on example role defintion

We're making a custom role definition, so we need to update the IsCustom property to True.

* Update New-AzRoleDefinition.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* [CognitiveServices] Unify and Complete samples (#21487)

* add some outputs for Get

* Update Get-AzCognitiveServicesAccountCommitmentPlan.md

* Update Get-AzCognitiveServicesAccountDeployment.md

* Update Get-AzCognitiveServicesAccountType.md

* Update Get-AzCognitiveServicesCommitmentPlan.md

* Update Get-AzCognitiveServicesCommitmentTier.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Add the Test Case to Verify All Environment Endpoints after Initialization (#21516)

* Add the Test Case to Verify All Environment Endpoints after Initialization

* Upgrade common library versions

* Modify some logic to support update NewtonSoftJson to 13.0.3 (#21529)

* Remove 7.1 support

* Remove 7.1 support

* [Storage] Add support for sticky bit  (#21528)

* Support for sticky bit

* delete redundant file

* Update help files

* update parameter description format

* Update help

* Fix the issue of static analysis

---------

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* [Storage] Fix the issue of listing blobs with leading slashes  (#21427)

* Fix for slash issue

* update GetTrack2BlobClient input

* update sdk dependency

* Add warning message for breaking change

* Update warning message

* Update warning message to apply to just the parameter

* GA for Az.LoadTesting (#21507)

* GA for Az.LoadTesting

* Add to Az.psd1

* Update Az.psd1

---------

Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>

* Added breaking changes for Invoke-AzKeyVaultKeyOperation (#21527)

* [SQL] Add ServerConfigurationOption cmdlets (#21535)

* Generate SDK

* Add cmdlets

* add tests

* add help files

* Update src/Sql/Sql/help/Az.Sql.md

* Update src/Sql/Sql/help/Az.Sql.md

* add online version to help files

* fix help examples

* fix static analysis err in examples

* Removed PowerShell 7.0 for live test and added placeholder for PowerShell latest (#21547)

* Removed ps 7.0 for live test and added ps latest

* Fixed issues

---------

Co-authored-by: Yunchi Wang <Yunchi.Wang@microsoft.com>

* Migrate MobileNetwork from generation to main (#21476)

* Move MobileNetwork to main

* update

* update changelog

---------

Co-authored-by: Jinpei Li <v-jinpel@microsoft.com>

* [Storage] Allowed to clear blob tags (#21560)

* Migrate Workloads from generation to main (#21562)

* Move Workloads to main

* Fix the issue of static analysis

---------

Co-authored-by: wyunchi-ms <yunwang@microsoft.com>

* [NetAppFiles] Update to 2022-09-01  (#21530)

* update to 2022-09-01 add tests

* Update help files

* Add properties to quota rules

* prompt in example

* UnlockNetAppFilesVolumeFileLock singular

* UnlockNetAppFilesVolumeFileLock singular

* Remove AccountBackupsOperations

* Update changelog

* Update changelog.

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Implemented live test email notification (#21565)

* Update Doc Issue #20625 (#21563)

* Update Doc Issue

* Update ExampleIssues

* Add deprecation warning message on WSC cmdlets (#21584)

* mark wsc cmdlets as deprecated

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Upgraded Azure.Data.Tables package to the latest v12.8.0 (#21577)

* [Storage] Support rename file and directory  (#21575)

* rename changes

* Update help

* update cmdlet config

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* update common reference (#21573)

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* feat: add autoscale support for virtual hub and update network formatting (#21518)

* feat: add autoscale support for virtual hub and update formatting

* docs: update changelog

* fix: update online

* tests: add exception to static analysis

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Register Microsoft.HardwareSecurityModules/cloudHsmClusters RP in Network cmdlets (#21598)

* Register Microsoft.HardwareSecurityModules/cloudHsmClusters RP in Network cmdlet

* Updated ChangeLog

---------

Co-authored-by: Demilade Oladugba <doladugba@microsoft.com>

* Added support for updating CrossSubscriptionRestoreState of the vault (#21583)

* Added support for updating CrossSubscriptionRestoreState of the vault
Added Cross subscription restore support for workload type MSSQL

* added new testcase

* Re-recorded backup test cases
Updated ASR tests
Generated site-recovery SDK
updated failed tests

* Parsing Skip token for next call (#21600)

* Parsing Skip token for next call

* Change log

* Regenerate help for Az.Network (#21533)

* docs: regenerate help for Az.Network

* test: update static analysis exceptions

* docs: fix autogeneration error

* docs: minor wording update

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Update Set-AzApplicationGatewayConnectionDraining.md (#21601)

Description section referenced the incorrect command: Set-AzApplicationGatewayWebApplicationFirewallConfiguration

* Support deploying Azure resources with parameters file described with the Bicep language  (#21567)

* add integration test for deployment using bicepparam

* add changes for bicepparam file deployment

* updated changelog

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Update Set-AzApplicationGatewayBackendAddressPool.md (#21458)

Updating with Set-AzApplicationGateway command without which the application gateway configuration changes are not saved.

* Added PackageAction `Set` for `Update-AzSynapseSparkPool` to support removing and adding packages in one action (#21579)

* Added AzureSynapseSparkPool PackageAction Set to allow removing and update of a package in one action

* updated Synapse/ChangeLog.md

* updated help file Update-AzSynapseSparkPool.md

* added PackageAction Set example to help file for Update-AzSynapseSparkPool command

---------

Co-authored-by: Morris Emming <morris.emming@brockhaus-ag.de>

* Fix issue for Update-AzCustomIpPrefix (#21609)

* Fix the issue when checking help examples in CI pipeline (#21620)

* update

* update

* release-2023-04-25 (#21622)

* Bump up versions

* Bump up versions

* Bump up versions

* Update Get-AzApiManagementAuthorizationServerClientSecret.md (#21619)

fixed small typo in "cient" instead of "client"

* break msg updates (#21617)

* Update Set-AzNetworkManagerSubscriptionConnection.md (#21621)

fix typo. "manger" should be "manager"

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Use AAD auth for PublishAzureWebApps (#21628)

* Use AAD auth for PublishAzureWebApps

* Update ChangeLog.md

---------

Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>

* Remove FtpsState assertion (#21632)

* Update Az Predictor version with new telemetry property name (#21615)

* Add more test cases

* Rename the two property names

* Update the version

* Add more test cases

* [CVE] Resolve CVEs by adding dependencies of newer version. (#21638)

* Resolve CVEs by adding dependencies of newer version.

* Restore denpendencies in Compute

* Bump up version for Az.Websites (#21636)

* Migrate AlertsManagement from generation to main (#21634)

* Move AlertsManagement to main

* revise code

* Update ChangeLog.md

---------

Co-authored-by: Nanxiang Liu <nanxiangliu@microsoft.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>

* Remove CVE denpendencies in Compute to replicate the issue (#21643)

* Update location in the operation result if its not present for New-AzManagedApplications (#21640)

* Reset the location header with the async operation URI

* Updated the changelog

Updated the changelog

* Updated agent pool from windows to linux (#21651)

* Migrate Resources from generation to main (#21653)

* Move Resources to main

* Update ChangeLog.md

---------

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Migrate MobileNetwork from generation to main (#21654)

* Move MobileNetwork to main

* Update changelog

---------

Co-authored-by: Jinpei Li <v-jinpel@microsoft.com>

* New-AzVmssConfig, Update-AzVmss, add OS Image Scheduled Events (#21268)

* dev and start test

* test

* test done

* enabled edit

* help doc

* empty commit

* cleanup

* fix statics

* changelog

* Update ChangeLog.md

* Update New-AzVmssConfig.md

---------

Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>

* Bump up version for Az and AzPreview (#21642)

* [Az.KeyVault] Included policy while importing Certificate to a KeyVault (#21472)

* Half way upload.

* Second time commit-halp way

* sync 4/2

* Done transfer to track2

* sync 4/5

* Complete import cert with policy

* complete all cases for policy

* Update ChangeLog

* Remove unnecessary lines

* Resolve comments

* Update pfx file name

* Update according to comments

* Remove unnecessary dependecies

* Modify the actions number

* Update the contentType validation

* solve paramaterset ambigious

* Update ChangeLog.md

* Merge the exceptions, update help file

* Merge the exceptions, update help file

* Resolve the comments 4/27

* Update descriptions of policyobject and policypath

* Fixed Kusto utility parameter issue (#21658)

* Updated agent pool from windows to linux

* Fixed Kusto util arguments issue and removed the unnecessary parameters from the list

* Migrate Az.Relay from SDK to autorest (#21572)

* Remove Relay

* Move Relay to wyunchi/relay-removed (#21564)

* Update Relay

* Update ChangeLog.md

---------

Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>

* Add denpendencies in Compute to resolve the CVE (#21649)

* Add denpendencies in Compute to resolve the CVE

* Update System.Security.Permissions from 4.5.0 to 4.7.0

* Update System.Security.Permissions from 4.5.0 to 4.7.0

* Update with the latest test coverage data (#21668)

* Update chenglog of Accounts. (#21671)

* Generated new sdk for 2022-11-01

* Fixed the config file

* Remove `HostNamePrefix` (#21526)

* Remove `HostNamePrefix`

* Add change log

* update markdown

* Add breakingChangeIssues.csv

* Updated System.Security.Cryptography.Xml to v4.7.1 due to security vulnerability (#21672)

* Fix typo in Update-AzWebAppTrafficRouting.md (#21667)

* Updated SDK

* updated SDK version

* Update Service Owner Names in Tests (#21674)

* initial updates

* change routeservicedev to vwan

* [MSGraph] add live test for MSGraph (#21656)

* add live test for MSGraph

* add live test for MSGraph

* remove platform

* Update TestLiveScenarios.ps1

* Fixed SDK version

---------

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: geologyrocks <ed.hughes93@gmail.com>
Co-authored-by: Kota Sudhakar Reddy <60102891+Kotasudhakarreddy@users.noreply.github.com>
Co-authored-by: Azure PowerShell <65331932+azure-powershell-bot@users.noreply.github.com>
Co-authored-by: Yan Xu <sheshouxy@gmail.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: NanxiangLiu <33285578+Nickcandy@users.noreply.github.com>
Co-authored-by: Vincent Dai <23257217+vidai-msft@users.noreply.github.com>
Co-authored-by: xtR0d666 <69706194+xtR0d666@users.noreply.github.com>
Co-authored-by: Aaron Zhang <aaron@Aarons-MacBook-Pro.local>
Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com>
Co-authored-by: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com>
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Co-authored-by: tianxinliu <121260442+tianxin-ms@users.noreply.github.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Co-authored-by: yifanz0 <100746763+yifanz0@users.noreply.github.com>
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Bogdan Ostojic <49651629+ostojicb@users.noreply.github.com>
Co-authored-by: Yunchi Wang <Yunchi.Wang@microsoft.com>
Co-authored-by: Jinpei Li <v-jinpel@microsoft.com>
Co-authored-by: Wei Wei <weiwei@microsoft.com>
Co-authored-by: Auðunn <audunnb@gmail.com>
Co-authored-by: JoyerJin <116236375+JoyerJin@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: yifanz7 <131133995+yifanz7@users.noreply.github.com>
Co-authored-by: Noah Koontz <noah@koontzs.com>
Co-authored-by: Demilade Oladugba <44144195+D-Alegria@users.noreply.github.com>
Co-authored-by: Demilade Oladugba <doladugba@microsoft.com>
Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>
Co-authored-by: ampravinr <40807962+ampravinr@users.noreply.github.com>
Co-authored-by: Jeremiah Mathers <105680141+jeremiahmathers@users.noreply.github.com>
Co-authored-by: Muhammad Usman <mohammadusmanxero@gmail.com>
Co-authored-by: Gitanjali Verma <36200368+gitanjali1993@users.noreply.github.com>
Co-authored-by: Morris Janatzek <morrisj@live.de>
Co-authored-by: Morris Emming <morris.emming@brockhaus-ag.de>
Co-authored-by: Adam Myatt <adammyatt@hotmail.com>
Co-authored-by: dannysongg <38927254+dannysongg@users.noreply.github.com>
Co-authored-by: kceiw <mahuang@microsoft.com>
Co-authored-by: Nanxiang Liu <nanxiangliu@microsoft.com>
Co-authored-by: raosuhas <suhasrao@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: yzt <zityang@microsoft.com>
Co-authored-by: Steve Matney <steve.matney@gmail.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants