Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization to IotHubRoutingEndpoint cmdlet #8334

Merged
merged 4 commits into from Jan 19, 2019

Conversation

anusapan
Copy link
Contributor

Description

Add a new optional parameter to select the encoding format in which data route to be in.

Checklist

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have no tests for these changes. Please add a scenario test.

@@ -19,6 +19,9 @@
-->
## Upcoming Release

## Version 1.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add your own version header. Put the new entry under ## Upcoming Release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -32,5 +32,5 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.1")]
[assembly: AssemblyVersion("1.0.1")]
[assembly: AssemblyFileVersion("1.0.1")]
[assembly: AssemblyVersion("1.0.2")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change these version numbers. They are changed automatically when we publish.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

MiYanni
MiYanni previously approved these changes Jan 18, 2019
Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiYanni MiYanni merged commit d796220 into Azure:master Jan 19, 2019
@chlahav chlahav modified the milestones: 2019-01-15, 2019-01-29 Jan 20, 2019
@anusapan anusapan deleted the iothub branch January 22, 2019 18:25
@anusapan anusapan restored the iothub branch January 22, 2019 18:38
@anusapan anusapan deleted the iothub branch January 22, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants