New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization to IotHubRoutingEndpoint cmdlet #8334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have no tests for these changes. Please add a scenario test.
src/IotHub/IotHub/ChangeLog.md
Outdated
@@ -19,6 +19,9 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add your own version header. Put the new entry under ## Upcoming Release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -32,5 +32,5 @@ | |||
// You can specify all the values or you can default the Build and Revision Numbers | |||
// by using the '*' as shown below: | |||
// [assembly: AssemblyVersion("1.0.1")] | |||
[assembly: AssemblyVersion("1.0.1")] | |||
[assembly: AssemblyFileVersion("1.0.1")] | |||
[assembly: AssemblyVersion("1.0.2")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change these version numbers. They are changed automatically when we publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a new optional parameter to select the encoding format in which data route to be in.
Checklist
CONTRIBUTING.md
platyPS
module