New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a template for customized Minecraft server on Ubuntu #374
Conversation
Hi @gbowerman, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
The following issues were detected in this pull request: Template: minecraft-on-ubuntu
|
The following issues were detected in this pull request: Template: minecraft-on-ubuntu
|
The following issues were detected in this pull request: Template: minecraft-on-ubuntu
|
I'm not sure if the numbering is funny but I don't see anything wrong with line 152, and this template works fine in my test branch. I do not see why this template is not valid. |
The following issues were detected in this pull request: Template: minecraft-on-ubuntu
|
I don't see anything wrong with this template |
To double check I made an exact replica of this template here (https://github.com/gbowerman/azure-minecraft). It deploys perfectly. I do not understand why acomghbot is saying there is an invalid resource. |
I don't know how the bot does it's verification but it looks to me like the line number is off by 1 (the error refers to parameter "name" which is 151 not 152). Assuming this is correct then perhaps the problem might be that there is no default value set for the dnsNameForPublicIP parameter. You could test this by providing a value for the name property in 151. |
No issues were found in this pull request. |
No issues were found in this pull request. |
and leaving it in the parameters template
No issues were found in this pull request. |
Thanks Ross. It likes the pull request once I set a default parameter in the azuredeploy-parameters file. Good catch. I don't know how the bot does it's verification but it looks to me like the line number is off by 1 (the error refers to parameter "name" which is 151 not 152). Assuming this is correct then perhaps the problem might be that there is no default value set for the dnsNameForPublicIP parameter. You could test this by providing a value for the name property in 151. — |
Hi guys, any update on this pull request? |
"imagePublisher": "Canonical", | ||
"imageOffer": "UbuntuServer", | ||
"OSDiskName": "osdiskforlinuxsimple", | ||
"newStorageAccountName": "[parameters('dnsNameForPublicIP')]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably make this a parameter. Otherwise somebody could enter myuniquednsname, then it appears as the name of the storage account and the vm
No issues were found in this pull request. |
Amended storage account name to not be confused with DNS name |
No issues were found in this pull request. |
No issues were found in this pull request. |
Adding a template for customized Minecraft server on Ubuntu
No description provided.