Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a template for customized Minecraft server on Ubuntu #374

Merged
merged 10 commits into from Jul 11, 2015
Merged

Adding a template for customized Minecraft server on Ubuntu #374

merged 10 commits into from Jul 11, 2015

Conversation

gbowerman
Copy link
Contributor

No description provided.

@azurecla
Copy link

azurecla commented Jul 6, 2015

Hi @gbowerman, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (guybo). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: minecraft-on-ubuntu

  • The contents in file metadata.json do not match the required schema: String 'Install a Minecraft Server on an Ubuntu VM using the Linux Custom Script Extension' exceeds maximum length of 64. Line 2, position 106.
  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The template resource '' at line '152' and column '10' is not valid. The name property cannot be null or empty'."}}

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: minecraft-on-ubuntu

  • The contents in file metadata.json do not match the required schema: String 'Install a Minecraft Server on an Ubuntu VM using the Linux Custom Script Extension' exceeds maximum length of 64. Line 2, position 106.
  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The template resource '' at line '152' and column '10' is not valid. The name property cannot be null or empty'."}}

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: minecraft-on-ubuntu

  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The template resource '' at line '152' and column '10' is not valid. The name property cannot be null or empty'."}}

@gbowerman
Copy link
Contributor Author

I'm not sure if the numbering is funny but I don't see anything wrong with line 152, and this template works fine in my test branch. I do not see why this template is not valid.

@acomghbot
Copy link

The following issues were detected in this pull request:

Template: minecraft-on-ubuntu

  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The template resource '' at line '152' and column '10' is not valid. The name property cannot be null or empty'."}}

@gbowerman
Copy link
Contributor Author

I don't see anything wrong with this template

@gbowerman
Copy link
Contributor Author

To double check I made an exact replica of this template here (https://github.com/gbowerman/azure-minecraft). It deploys perfectly. I do not understand why acomghbot is saying there is an invalid resource.

@SorraTheOrc
Copy link
Contributor

I don't know how the bot does it's verification but it looks to me like the line number is off by 1 (the error refers to parameter "name" which is 151 not 152). Assuming this is correct then perhaps the problem might be that there is no default value set for the dnsNameForPublicIP parameter.

You could test this by providing a value for the name property in 151.

@acomghbot
Copy link

No issues were found in this pull request.

@acomghbot
Copy link

No issues were found in this pull request.

and leaving it in the parameters template
@acomghbot
Copy link

No issues were found in this pull request.

@gbowerman
Copy link
Contributor Author

Thanks Ross. It likes the pull request once I set a default parameter in the azuredeploy-parameters file. Good catch.
GuyDate: Sun, 5 Jul 2015 22:36:10 -0700
From: notifications@github.com
To: azure-quickstart-templates@noreply.github.com
CC: guybo@outlook.com
Subject: Re: [azure-quickstart-templates] Adding a template for customized Minecraft server on Ubuntu (#374)

I don't know how the bot does it's verification but it looks to me like the line number is off by 1 (the error refers to parameter "name" which is 151 not 152). Assuming this is correct then perhaps the problem might be that there is no default value set for the dnsNameForPublicIP parameter.

You could test this by providing a value for the name property in 151.


Reply to this email directly or view it on GitHub.

@gbowerman
Copy link
Contributor Author

Hi guys, any update on this pull request?

"imagePublisher": "Canonical",
"imageOffer": "UbuntuServer",
"OSDiskName": "osdiskforlinuxsimple",
"newStorageAccountName": "[parameters('dnsNameForPublicIP')]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably make this a parameter. Otherwise somebody could enter myuniquednsname, then it appears as the name of the storage account and the vm

@acomghbot
Copy link

No issues were found in this pull request.

@gbowerman
Copy link
Contributor Author

Amended storage account name to not be confused with DNS name

@acomghbot
Copy link

No issues were found in this pull request.

@acomghbot
Copy link

No issues were found in this pull request.

singhkays added a commit that referenced this pull request Jul 11, 2015
Adding a template for customized Minecraft server on Ubuntu
@singhkays singhkays merged commit f8a6bd7 into Azure:master Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants