Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TP Template #6256

Merged
merged 1 commit into from Jul 2, 2019
Merged

Conversation

YuanhengYang
Copy link
Contributor

@YuanhengYang YuanhengYang commented Jun 24, 2019

Change TP Template to use DSC.

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use a parameter for resource locations with the defaultValue set to resourceGroup().location
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values)
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/best-practices.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

Change TP Template to use DSC.

Change TP Template to use DSC.
@yizhongwu
Copy link
Contributor

The main purpose of this change is:
To use DSC instead of CustomScriptExtension, it is more stable per our testing. With DSC, we also don't need to pass password with plain text. It is more secure.
To use WS19 for private domain machine and remote DPMP machine

@yizhongwu
Copy link
Contributor

@bmoore-msft Hi Brian, we are finished testing on this. May you help review and merge it? Appreciated!

@bmoore-msft bmoore-msft merged commit 977dd7c into Azure:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants