Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistakes in exception handling HybridConnectionListener #71

Open
consultantleon opened this issue May 18, 2020 · 2 comments
Open

Mistakes in exception handling HybridConnectionListener #71

consultantleon opened this issue May 18, 2020 · 2 comments
Assignees
Labels

Comments

@consultantleon
Copy link

We noticed a race condition occurring after a network disruption, the HybridConnectionListener continues to loop and does not properly detect the error and commence a fresh reconnection cycle.

The reason seems to be in the wrong runtime exceptions being caught in HybridConnectionListener.java.

I also removed all unnecessary throws and replaced catch(Throwable) by more specific exception after having run the code agains our sonar setup.

I advised our Microsoft representative to run your code against a standard code checking tool such as Sonar to take this kind of mistakes out the code! See attached my version of HybridConnectionListener.java - which we updated after your dev commit of Feb 7 (== 0.3 release version).
HybridConnectionListener.java.txt

@jfggdl
Copy link

jfggdl commented Jun 9, 2020

@consultantleon, Thank you for reporting these code problems. Would you be able to create a PR?

@dlstucki dlstucki added the Relay label Jun 9, 2020
@consultantleon
Copy link
Author

sorry didn't see your comment - I wasn't sure how to create a branch & PR on this project. Was any action taken by you to correct the issue yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants