GA of 2019-01-01-preview and 2020-05-01-preview versions as one version: 2021-04-01 #16948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eview/2019-01-01-preview to version 2021-04-01
nickgmicrosoft
requested review from
ArcturusZhang,
BigCat20196,
msyyc and
RAY-316
as code owners
|
Hi, @nickgmicrosoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L703 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'B2CTenants_Create' Request Model: 'CreateTenantRequestBody' Response Model: 'B2CTenantResource' Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L205 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L840 |
|
| 'checkNameAvailabilityRequestBody' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L59 |
|
| 'createTenantRequestBody' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L229 |
|
| 'updateTenantRequestBody' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L293 |
|
| 'B2CTenantResource' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L909 |
|
| 'properties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json#L1002 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| "details":"Attention: There are some existing APIs currently documented in a new spec file. The validation may not be able to report breaking changes with these APIs. It is recommended not to rename swagger file or move public APIs to a new file when creating a new API version.The existing APIs being moved are:GuestUsages_ListByResourceGroup;", "location":"https://github.com/Azure/azure-rest-api-specs/blob/8a12d9a97c32cd1820a045e60b126ad3104d5b3e/specification/cpim/resource-manager/Microsoft.AzureActiveDirectory/stable/2021-04-01/externalIdentities.json" |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @nickgmicrosoft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
Swagger Generation Artifacts
|
|
Hi, @nickgmicrosoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
openapi-pipeline-app
bot
added
NewApiVersionRequired
and removed
NewApiVersionRequired
labels
j5lim
added
ARMSignedOff
msyyc
approved these changes
Dec 8, 2021
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
|
Hi, @nickgmicrosoft. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @nickgmicrosoft. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-BreakingChange-Go
labels
|
Ready to merge |
This was referenced Feb 14, 2022
Closed
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…on: 2021-04-01 (Azure#16948) * Adds base for updating Microsoft.AzureActiveDirectory from version preview/2019-01-01-preview to version 2021-04-01 * Updates readme * Updates API version in new specs and examples * combining two existing preview versions into one GA version * touching up readme files * removing changes to existing files * copying over guestusages entries into new version * addressing lint errors * fixing additionalProperties * fixing errors with example for guestusages * fixing formatting issues * using alternative form of additionalProperties * fixing long running error tags for get * adding flattening and correct folder path for go * addressing systemData and operation api response schema issues * fixing missing comma * fixing reference to v2/types' * fixing reference to v2/types' * fixing reference to v2/types' * removing operation properties * Update specification/cpim/resource-manager/readme.md Removing track1 Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * azureadexternalidentities name for python * removing async operation * adding 200 for delete operation and removing reference to nickgomez97 * making go version compatible with track2 * adding flag for track2 for go * renaming service folder name * fixing name miss for azureadexternalidentities from externalidentities in go file * removing csharp file, not needed for now * adding back csharp file and fixing GeneratedProtocol to Generated * reverting folder name change - introduces too many errors * modelAsString=true for enums * sligth change to trigger checks again Co-authored-by: Edwin Gomez Cuellar <edwingomezcuellar@DESKTOP-26P66H4.corp.microsoft.com> Co-authored-by: Edwin Gomez Cuellar <edwingomezcuellar@Edwins-MacBook-Pro.local> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.