Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdn: adding missing x-ms-enum's #17987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cdn: adding missing x-ms-enum's #17987

wants to merge 1 commit into from

Conversation

tombuildsstuff
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2022 •
    edited

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3295
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3398
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3451
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3508
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3561
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3618
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3671
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3677
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3719
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 24, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 24, 2022 •
    edited

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @ghost
    Copy link

    ghost commented Feb 24, 2022

    Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

    This was referenced Feb 24, 2022
    Draft
    Draft
    This was referenced Feb 24, 2022
    Draft
    Draft
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 24, 2022
    Draft
    @ghost
    Copy link

    ghost commented Mar 13, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Mar 13, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    This is waiting for the Service Team to review it...

    @ghost ghost removed the no-recent-activity label Mar 14, 2022
    @ghost
    Copy link

    ghost commented Apr 3, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Apr 3, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    Waiting on the service team to review it.

    @ghost ghost removed the no-recent-activity label Apr 4, 2022
    @ghost
    Copy link

    ghost commented Apr 24, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Apr 24, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    Waiting on the service team to review it.

    @ghost ghost removed the no-recent-activity label Apr 27, 2022
    @ghost
    Copy link

    ghost commented May 15, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost
    Copy link

    ghost commented Aug 28, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Aug 28, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    As above

    @ghost ghost removed the no-recent-activity label Aug 28, 2022
    @ghost
    Copy link

    ghost commented Sep 18, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 18, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    As above..

    @ghost ghost removed the no-recent-activity label Sep 19, 2022
    @ghost
    Copy link

    ghost commented Oct 9, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Oct 9, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    Same as before: #17987 (comment)

    @ghost ghost removed the no-recent-activity label Oct 14, 2022
    @ghost
    Copy link

    ghost commented Oct 30, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Oct 30, 2022
    @tombuildsstuff
    Copy link
    Contributor Author

    Still waiting for a review..

    @ghost ghost removed the no-recent-activity label Oct 31, 2022
    tombuildsstuff added a commit to tombuildsstuff/azure-rest-api-specs that referenced this pull request Nov 14, 2022
    @tombuildsstuff
    tooling: removing the auto-close bot
    494dc30 
    This commit fixes Azure#19098 by removing the auto-close bot.

Whilst I can understand that Service Teams maybe unable to review all Pull Requests
in a timely manner, unfortunately I've had a number of Pull Requests at this point
which end up with me posting every 2 weeks to keep the Pull Request open:

* Azure#17987 (comment)
* Azure#18269 (comment)

Whilst this does mean there'll be more Pull Requests open until the Service Team can
take a look at them - removing this user hostile bot improves the contribution experience.
    @tombuildsstuff tombuildsstuff mentioned this pull request Nov 14, 2022
    Closed
    @ghost
    Copy link

    ghost commented Nov 27, 2022

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Nov 27, 2022
    @ruowan
    Copy link
    Member

    ruowan commented Nov 28, 2022

    Hi, @tombuildsstuff I help you to ping the service team on teams. Hope they will review your PR.

    @ghost ghost removed the no-recent-activity label Nov 28, 2022
    @ruowan ruowan self-assigned this Nov 28, 2022
    @ghost
    Copy link

    ghost commented Jul 9, 2023

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Jul 9, 2023
    @tombuildsstuff
    Copy link
    Contributor Author

    @ruowan any update here?

    @openapi-pipeline-app openapi-pipeline-app
    Copy link

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has breaking changes in the generated SDK for javascript (label: CI-BreakingChange-JavaScript). Refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jorinmejia jorinmejia Awaiting requested review from jorinmejia jorinmejia is a code owner

    @t-bzhan t-bzhan Awaiting requested review from t-bzhan t-bzhan is a code owner

    At least 1 approving review is required to merge this pull request.

    Assignees

    @ruowan ruowan

    Labels
    Approved-SdkBreakingChange-Python CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    None yet
    3 participants
    @tombuildsstuff @ruowan @msyyc