Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Microsoft.App 2022-11-01-preview #22896

Merged
merged 53 commits into from
Mar 28, 2023
Merged

Release Microsoft.App 2022-11-01-preview #22896

merged 53 commits into from
Mar 28, 2023

Conversation

howang-ms
Copy link
Contributor

@howang-ms howang-ms commented Mar 3, 2023 •
edited by Juliehzl

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

p-bouchon and others added 30 commits October 3, 2022 11:02
@p-bouchon
Adds base for updating Microsoft.App from version preview/2022-06-01-…
0ae8de5 
…preview to version 2022-10-01
@p-bouchon
Updates readme
db82f23
@p-bouchon
Updates API version in new specs and examples
ec20514
@ruslany
Adds base for updating Microsoft.App from version stable/2022-10-01 t…
a0b5838 
…o version 2022-11-01-preview
@ruslany
Updates readme
57fef78
@ruslany
Updates API version in new specs and examples
b6e8461
@ruslany
Add AppState and LatestReadyRevisionName (Azure#21034) (Azure#21087)
5533d83 
* Add new props

* add defaults
@Juliehzl
Fix certificate password format of env custom domain for 2022-11-01-p…
5f5ce9c 
…review (Azure#21464)

* fix

* fix
@ruslany
Remove AppState property as we decided to postpone it (Azure#21484)
796232b 
* Remove AppState property as we decided to postpone it

* Fix swagger issues

* fix swagger issues

* More swagger fixes

* Swagger fixes

* additional fix

* Even more swagger fixes - where does this come from?

* Fix other swagger issues

* fixing remaining swagger issues
@najian
fix S360 swagger correctness errors (Azure#21478)
accc4a8 
* fix S360 swagger correctness errors

* add default value

Co-authored-by: Nan Jiang <naji@microsoft.com>
@zhenqxuMSFT
Add swagger for client cert & CORS policy (Azure#21345)
f43f5d1 
* Add swagger for client cert & CORS policy (Azure#21126)

* Add certificate & CORS Policy

* try fix
@Juliehzl
add (Azure#21554)
843dd69
@navba-MSFT
{AzureContainerApps} fixes Azure#21354 (Azure#21520)
e07bd8a 
* {AzureContainerApps} fixes Azure#21354

runtimeSubnetId was the old way of doing it and now it is no longer needed.
It is very confusing to still see it being used or required in API specification documentation below:

https://learn.microsoft.com/en-us/azure/templates/microsoft.app/managedenvironments?pivots=deployment-language-bicep#vnetconfiguration

This PR updates the description mentioning it is deprecated.

* Update ManagedEnvironments.json

* Update ManagedEnvironments.json

* Update ManagedEnvironments.json

* Update ManagedEnvironments.json
add managed cert API in 2022-11-01-preview (Azure#21281)
8503e96 
* add managed cert API in 2022-11-01-preview

* prettierred

Co-authored-by: Elle Tojaroon <patojaro@microsoft.com>
@chinadragon0515
Add controlPlaneSubnetId for AKS API server injection (Azure#21718)
678bb82 
Co-authored-by: Vincent He <dashe@microsoft.com>
@tdaroly
Sticky Sessions Swagger PR (Azure#21521)
f34c7cc 
* add sticky sessions first commit

* add examples

* fix semantic validation

* remove breaking sdk error's duplicates

* fix camelCase error

* remove extra attributes

* change affinity property to a string enum

* change Sticky -> sticky

* pretty errir

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
@yalixiang
Add keda/dapr version. (Azure#21982)
f90b24b 
* Add keda/dapr version.

* Fix.
@ruslany
Add managedBy property to the containerapps ARM envelope (Azure#22059)
58741ee 
* Add managedBy property to the containerapps ARM envelope

* Add missing prop from previous version

* Add managedBy example

* Fix ci issues

* Allow update of managedBy
Revert "Add controlPlaneSubnetId for AKS API server injection (Azure#…
6772486 
…21718)" (Azure#22149)

This reverts commit 678bb82.
@zhenqxuMSFT
Add quotas property to managed environment (Azure#22169)
6c10168 
* Add quotas property to managed environment

* lint
@zhenqxuMSFT
Remove quota from ManagedEnvironments (Azure#22441)
82be6d3
@anandanthony
Add container apps job specs (Azure#21916)
23e82ab 
* Adding Container App Jobs specs for review

* Adding Container App Jobs specs for review

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | fix validations

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* Adding Container App Jobs specs for review | address comments

* updating sub-resource name to jobs from containerAppsJobs

* updating sub-resource name to jobs from containerAppsJobs

* updating sub-resource name to jobs from containerAppsJobs

* updating sub-resource name to jobs from containerAppsJobs

* updating sub-resource name to jobs from containerAppsJobs

* revert resource management version

* revert resource management version

* revert resource management version
@chinadragon0515
Remove never used properties (Azure#22423)
27489e4 
Co-authored-by: Vincent He <dashe@microsoft.com>
@najian
Fix S360 certificateId not required. (Azure#22426)
2f01a7c 
* Fix S360 certificateId not required

* Fix example

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>
@xwang971
Add properties for secrets from KV (Azure#22652)
a431788 
* add properties for secrets from KV

* typo

* remove unnecessay examples
@anandanthony
Add specs for start, stop & executions for Container Apps Jobs (Azure…
671716d 
…#22594)

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update job specs with start, stop, execution endpoints

* update job specs with start, stop, execution endpoints

* update job specs with start, stop, execution endpoints

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs

* update start stop spec for jobs
@smzeng
mount secret as volume arm changes (Azure#22688)
ae35416 
* add secret volume type to common definitions

* updated common definitions for secrets to be an array of secret item objects

---------

Co-authored-by: Stacy Zeng <stacyzeng@microsoft.com>
@jijohn14
Remove enum for category properties (Azure#22658)
b8a7057 
* remove enum category properties

* Rename property to category in available workload profiles

* Remove premium from description

* Update example
@ebencarek
Add infrastructure rg (Azure#22653)
2e26b9f 
* Add infrastructureResourceGroup propery to managedEnvironments

* Updated examples

* fix indentation

* Update examples ref
@zhenqxuMSFT
Update description for CORS policy properties (Azure#22442)
ab11e4d 
* Update description for CORS policy properties

* Fix 2022-10-01 PATCH response

* fix

* fix
@archerzz
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk azure-sdk mentioned this pull request Mar 23, 2023
Closed
@mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 23, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2023
@raosuhas
Copy link

This PR does not have the base commit for the 2022-11-01-preview version. This is explained above in the comment :

image

@raosuhas
Copy link

PLease add the base commit before starting the ARM review

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 23, 2023
@openapi-workflow-bot
Copy link

Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 23, 2023
@Juliehzl
Copy link
Contributor

Juliehzl commented Mar 24, 2023 •
edited

PLease add the base commit before starting the ARM review

What is the base commit you mentioned? Is this one a0b5838?

BTW, all changes in this PR already get ARM reviews in separated PR. Here is our feature branch https://github.com/Azure/azure-rest-api-specs/commits/release-app-Microsoft.App-2022-11-01-preview/specification/app.

@tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Mar 28, 2023
@ArthurMa1978 ArthurMa1978 merged commit 905a9ad into Azure:main Mar 28, 2023
This was referenced Mar 28, 2023
Closed
Closed
Closed
Closed
Closed
Closed
JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
@JoshLove-msft
Release Microsoft.App 2022-11-01-preview (Azure#22896)
45305dc
This was referenced May 5, 2023
Merged
Merged
@Alancere Alancere mentioned this pull request May 16, 2023
Merged
@ahmelsayed ahmelsayed mentioned this pull request May 19, 2023
Merged
11 tasks
@tadelesh tadelesh mentioned this pull request May 25, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliehzl Juliehzl Juliehzl approved these changes

@trajkobal trajkobal trajkobal approved these changes

Assignees

@archerzz archerzz

@JeffreyRichter JeffreyRichter

Labels
Approved-Avocado Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure CI-MissingBaseCommit new-api-version resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet