-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data-plane] Initial Creation of HealthDataAiServices.Deid 2 #27563
[data-plane] Initial Creation of HealthDataAiServices.Deid 2 #27563
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2024-01-31-preview | package-2024-01-31-preview(eea9318) | default(release-healthdataaiservices-deidentification-2024-01-31-preview) |
default | default(eea9318) | default(release-healthdataaiservices-deidentification-2024-01-31-preview) |
[must fix]The following errors/warnings are introduced by current PR:
️❌
Avocado: 3 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: data-plane/Microsoft.HealthDataAIServices/preview/2024-01-31-preview |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.HealthDataAIServices/preview/2024-01-31-preview/examples |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: eea93183b67d90defa76c8d5eda6c427f957c889/specification/deidentification/data-plane |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️❌
TypeSpecAPIView: 0 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
"How to fix":"Check the detailed log and verify if the TypeSpec emitter is able to create API review file for the changes in PR." |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Was getting unexplainable pipeline failures in last PR: #27452 Also the bot appeared to believe it was an ARM PR? Just throwing the whole thing away and trying again. Recreated in hope of fixing them. |
Hi @GrahamMThomas! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for private preview. 👍
Removed auto-assigned reviewers and added @weidongxu-microsoft since he had comments on the original #27452. |
b6c2132
into
Azure:release-healthdataaiservices-deidentification-2024-01-31-preview
@doc("Data type of the input documents.") | ||
dataType: DocumentDataType = DocumentDataType.PlainText; | ||
|
||
@doc("Operation to perform on the input documents.") | ||
operation: OperationType = OperationType.Redact; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these would be service default. It won't affect client behavior.
@doc("Job has completed with at least 1 file failing.") | ||
PartialFailed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a terminal state?
Service should not add a terminal state.
@@ -0,0 +1,37 @@ | |||
parameters: | |||
"service-dir": | |||
default: "sdk/deid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, folder and package name likely be wrong.
These can be modified after your SDK arch review.
This one may need service action #27563 (comment) |
…7563) Initial Creation of HealthDataAIServices Deid Service Spec. --------- Co-authored-by: Graham Thomas <gthomas@microsoft.com>
…7563) Initial Creation of HealthDataAIServices Deid Service Spec. --------- Co-authored-by: Graham Thomas <gthomas@microsoft.com>
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Checks stuck in `queued` state?
If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.