Added usage models for run and runStep #28864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
jpalvarezl
merged commit 7a6e0f3
into
user/travisw/assistants-streaming-models-draft
25 of 29 checks passed
lmazuel
pushed a commit
that referenced
this pull request
May 24, 2024
… models (#28555) * initial commit for models in support of streaming Assistants calls * merge + pr feedback * [OpenAI] [Assistants] PR feedback (#28786) * Adding streaming events and modified class visibilities * Represented the alias as a union to align better with the swagger and have a class generated * Adding chunk classes to be included on code emission * Update specification/ai/OpenAI.Assistants/streaming/events.tsp * Added usage models for run and runStep (#28864) * Added usage models for run and runStep * Added added annotation * Added warning suppresion for nullable fields * Compiled with new models and unions * back ported everything to a past version. Extracted SubmitToolOutputsOptions model * re-compile * Removed toolresources for now and added warning supressions * Brought up to date the classes related to streaming for AssistantStreamEvent * Making filename mandatory uploadFile operation * Project compilation * Re-formated definitiones according to CI instructions * Added missing documentation * Reverted nullability of fileName * re-compiled * Removed openapi v2 and v3 files generated with the placeholder version * reformating * Maded the stream events public to expose types and docs to users * Made stream events publics * remove single-use options model, merge into route params directly * proactively add 2024-05-01-preview label * Removed 05_01 from service version enum ... for now * Added string type to AssistantStreamEvent * tsp validation check --------- Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Jose Alvarez <josealvar@microsoft.com>
lmazuel
pushed a commit
that referenced
this pull request
May 31, 2024
* initial commit for models in support of streaming Assistants calls * merge + pr feedback * [OpenAI] [Assistants] PR feedback (#28786) * Adding streaming events and modified class visibilities * Represented the alias as a union to align better with the swagger and have a class generated * Adding chunk classes to be included on code emission * Update specification/ai/OpenAI.Assistants/streaming/events.tsp * Added usage models for run and runStep (#28864) * Added usage models for run and runStep * Added added annotation * Added warning suppresion for nullable fields * Compiled with new models and unions * back ported everything to a past version. Extracted SubmitToolOutputsOptions model * re-compile * Removed toolresources for now and added warning supressions * Brought up to date the classes related to streaming for AssistantStreamEvent * Making filename mandatory uploadFile operation * Project compilation * Re-formated definitiones according to CI instructions * Added new service version * Figuring out error highlights in vscode * Added get method listVectorStore * extracted union * Added create vector store method * Adding method to get single vector store * Added update methods for vector store * Added deletion method for vector stores * Removed assistant specific file models and operations * Added operation for listing vector store files * Added create file for vector store method * Added the rest of the file operations * Re-structured files under vector_store * Reformated correctly * Added first operation for vector store file batch * Added file listing per vector store file batch * WIP: AssistantsApiResponseFormatOption generates as anyOf of instead of oneOf * corrected values for enum * Adjusted Assistant response object * Added browse azure tool call type and renamed retrieval to file_search * Adding models for createAssistantsOptions * Updated assistant update models * Added TruncationObject * Added tool_choice to run related objects * Added new fields to ThreadRun model * Added attachements and tool resources to thread and message related models * 2nd pass to thread and message related files * Renamed 'retrieva'->'file_search' added 'browse' * Removed deprecated file endpoints and add java customizations for code gen * Spellchecks * Added missing documentation * -clear * Renamed union * TSP validation check * Reverted nullability of fileName * re-compiled * Added new file purposes * Removed openapi v2 and v3 files generated with the placeholder version * reformating * Added AOAI fields for Files * Added missing tool_resource object to createThreadAndRunRequest * Updated docs and removed Browse tools for this release * Maded the stream events public to expose types and docs to users * Made stream events publics * PR feedback and solved one open comment left for UpdateThreadOptions * remove single-use options model, merge into route params directly * proactively add 2024-05-01-preview label * Removed model removed in upstream branch * Recompile * Removed 05_01 from service version enum ... for now * Restored example * Added string type to AssistantStreamEvent * tsp validation check * Duplicate doc annotation * Removed duplicate entries * Added documentation for API response formats * Applied formatter * Removed package and annotation usage causing issues in Java emitter * Made temperature and top_p nullable for assistant create request * Commented out linter rule breaking code emission * Corrected double dot in documentation * Restored linter rules for formater and adjusted definition of JSON polymorphic type * Cleaned up comment * Split out the string variants into their own union * tsp format * PR feedback --------- Co-authored-by: Travis Wilson <travisw@microsoft.com> Co-authored-by: Travis Wilson <35748617+trrwilson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing streaming in Java, I noticed in the JSON that there is usage data available that we could be deserializing. Maybe this is not the right PR to address this so feel free to ignore for now :)
Reference lines in swagger: