Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version #28946

annapankiewicz · 2024-05-02T16:34:43Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- Remove deprecated Microsoft.NetworkCloud API version 2023-05-01-preview.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-05-02T16:34:47Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-05-02T16:34:47Z

Swagger Validation Report

️❌BreakingChange: 289 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
TrafficController.json	2023-11-01(5488612)	2023-11-01(main)
AdvancedThreatProtectionSettings.json	2024-02-01-preview(5488612)	2024-02-01-preview(main)
FlexibleServers.json	2024-02-01-preview(5488612)	2024-02-01-preview(main)
networkcloud.json	2023-05-01-preview(5488612)	2023-05-01-preview(main)
TrafficController.json	2024-05-01-preview(5488612)	2024-05-01-preview(main)

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/advancedThreatProtectionSettings/{advancedThreatProtectionName}' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/AdvancedThreatProtectionSettings.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/advancedThreatProtectionSettings' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/AdvancedThreatProtectionSettings.json#L232:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L271:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBforMySQL/flexibleServers' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L313:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/failover' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L352:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/validateEstimateHighAvailability' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L400:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/restart' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L451:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/start' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L508:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/stop' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L556:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/resetGtid' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L604:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/detachVNet' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L664:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/replicas' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L727:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBforMySQL/flexibleServers/{serverName}/cutoverMigration' removed or restructured? Old: FlexibleServers/preview/2024-02-01-preview/FlexibleServers.json#L772:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.NetworkCloud/operations' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L19:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/bareMetalMachines' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L53:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/cloudServicesNetworks' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L90:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/clusterManagers' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L127:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/clusters' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L164:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/kubernetesClusters' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L201:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/l2Networks' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L238:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/l3Networks' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L275:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/rackSkus' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L312:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/rackSkus/{rackSkuName}' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L349:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/racks' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L386:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/storageAppliances' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L423:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/trunkedNetworks' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L460:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/virtualMachines' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L497:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.NetworkCloud/volumes' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L534:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetworkCloud/bareMetalMachines' removed or restructured? Old: Microsoft.NetworkCloud/preview/2023-05-01-preview/networkcloud.json#L571:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Compared specs (v2.2.2)	new version	base version
default	default(5488612)	default(main)

️❌Avocado: 1 Errors, 1 Warnings failed [Detail]

Rule	Message
`❌` MULTIPLE_DEFAULT_TAGS	The readme file has more than one default tag. readme: specification/mysql/resource-manager/readme.md
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/mysql/resource-manager/readme.md tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-02T16:34:48Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded in generating from 53aa6cf. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.101 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/networkcloud/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
warn	No package detected after generation

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 53aa6cf. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-networkcloud [Preview SDK Changes]

azure-mgmt-networkcloud-1.0.0b1.zip
azure_mgmt_networkcloud-1.0.0b1-py3-none-any.whl

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ClustersOperations.begin_scan_runtime
info	[Changelog]   - Model AgentPoolPatchParameters has a new parameter administrator_configuration
info	[Changelog]   - Model BareMetalMachine has a new parameter machine_roles
info	[Changelog]   - Model BareMetalMachine has a new parameter runtime_protection_status
info	[Changelog]   - Model Cluster has a new parameter runtime_protection_configuration
info	[Changelog]   - Model Cluster has a new parameter secret_archive
info	[Changelog]   - Model Cluster has a new parameter update_strategy
info	[Changelog]   - Model ClusterPatchParameters has a new parameter runtime_protection_configuration
info	[Changelog]   - Model ClusterPatchParameters has a new parameter secret_archive
info	[Changelog]   - Model ClusterPatchParameters has a new parameter update_strategy
info	[Changelog]   - Model ControlPlaneNodePatchConfiguration has a new parameter administrator_configuration
info	[Changelog]   - Model KeySetUser has a new parameter user_principal_name
info	[Changelog]   - Model KubernetesClusterPatchParameters has a new parameter administrator_configuration

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 53aa6cf. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-networkcloud [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-networkcloud-1.1.0-beta.1.jar
- azure-resourcemanager-networkcloud-1.1.0-beta.1-sources.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 53aa6cf. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/networkcloud/armnetworkcloud [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 53aa6cf. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-networkcloud [Preview SDK Changes]
- azure-arm-networkcloud-1.1.0-beta.1.tgz

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from 53aa6cf. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.8.0` to update!
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-02T16:34:48Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/networkcloud/armnetworkcloud	https://apiview.dev/Assemblies/Review/c89915ca137f4e71ba1bb8690c10382a?revisionId=c0e3453890e74c979018020237d8478d
Java	azure-resourcemanager-networkcloud	https://apiview.dev/Assemblies/Review/6b36b1d00abd4a3a91061a25e519b24d?revisionId=168c03785a8144c380314e2730bf1f0d
JavaScript	@azure/arm-networkcloud	https://apiview.dev/Assemblies/Review/32bd6e5951f74d5d8c7c1b0176e9c67b?revisionId=71037fd81c3a4e478c96bb4a486d3168

annapankiewicz · 2024-05-02T16:35:24Z

PR created based on updates to the private spec repo, which has been approved and merged: https://github.com/Azure/azure-rest-api-specs-pr/pull/18027

mikekistler · 2024-05-07T00:31:24Z

Breaking changes previously reviewed and approved in https://github.com/Azure/azure-rest-api-specs-pr/pull/18027

annapankiewicz · 2024-05-07T00:34:41Z

/azp run

azure-pipelines · 2024-05-07T00:34:58Z

Azure Pipelines successfully started running 4 pipeline(s).

annapankiewicz · 2024-05-16T19:08:22Z

/azp run

azure-pipelines · 2024-05-16T19:08:41Z

Azure Pipelines successfully started running 4 pipeline(s).

annapankiewicz · 2024-05-22T16:25:31Z

/pr RequestMerge

…eview

…zure#28946) Co-authored-by: Anna Pankiewicz <anna.pankiewicz@microsoft.com> Co-authored-by: Razvan Badea <156206747+razvanbadea-msft@users.noreply.github.com>

Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version

ca3106c

mikekistler added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label May 7, 2024

AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 7, 2024

razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 22, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 22, 2024

microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label May 22, 2024

razvanbadea-msft removed the MergeRequested Part of the ARM PR review workflow label May 23, 2024

razvanbadea-msft added the MergeRequested Part of the ARM PR review workflow label May 23, 2024

Merge branch 'main' into annapankiewicz/networkcloud/remove20230501pr…

5488612

…eview

AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label May 23, 2024

razvanbadea-msft approved these changes May 23, 2024

View reviewed changes

razvanbadea-msft merged commit 6f69407 into main May 23, 2024
29 of 32 checks passed

razvanbadea-msft deleted the annapankiewicz/networkcloud/remove20230501preview branch May 23, 2024 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version #28946

Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version #28946

annapankiewicz commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

annapankiewicz commented May 2, 2024

mikekistler commented May 7, 2024

annapankiewicz commented May 7, 2024

azure-pipelines bot commented May 7, 2024

annapankiewicz commented May 16, 2024

azure-pipelines bot commented May 16, 2024

annapankiewicz commented May 22, 2024

Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version #28946

Remove deprecated Microsoft.NetworkCloud 2023-05-01-preview version #28946

Conversation

annapankiewicz commented May 2, 2024 • edited

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented May 2, 2024 • edited

Next Steps to Merge

openapi-pipeline-app bot commented May 2, 2024 • edited

Swagger Validation Report

openapi-pipeline-app bot commented May 2, 2024 • edited

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 2, 2024 • edited

Generated ApiView

annapankiewicz commented May 2, 2024

mikekistler commented May 7, 2024

annapankiewicz commented May 7, 2024

azure-pipelines bot commented May 7, 2024

annapankiewicz commented May 16, 2024

azure-pipelines bot commented May 16, 2024

annapankiewicz commented May 22, 2024

annapankiewicz commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited

openapi-pipeline-app bot commented May 2, 2024 •

edited