-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new GA version: 2023-12-30 for Microsoft.DBForMySQL #29031
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
AzureADAdministrator.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
AzureADAdministrator.json | 2023-12-30(52b1a2d) | 2023-06-01-preview(main) |
BackupAndExport.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
BackupAndExport.json | 2023-12-30(52b1a2d) | 2023-10-01-preview(main) |
Backups.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
Backups.json | 2023-12-30(52b1a2d) | 2023-10-01-preview(main) |
LongRunningBackups.json | 2023-12-30(52b1a2d) | 2023-10-01-preview(main) |
Configurations.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
Configurations.json | 2023-12-30(52b1a2d) | 2023-06-01-preview(main) |
Databases.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
Databases.json | 2023-12-30(52b1a2d) | 2023-06-01-preview(main) |
FirewallRules.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
FirewallRules.json | 2023-12-30(52b1a2d) | 2023-06-01-preview(main) |
LogFiles.json | 2023-12-30(52b1a2d) | 2023-06-30(main) |
LogFiles.json | 2023-12-30(52b1a2d) | 2023-06-01-preview(main) |
Maintenances.json | 2023-12-30(52b1a2d) | 2023-10-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-flexibleserver-2024-02-01-preview | package-flexibleserver-2024-02-01-preview(52b1a2d) | package-flexibleserver-2024-02-01-preview(main) |
package-flexibleserver-2024-01-01 | package-flexibleserver-2024-01-01(52b1a2d) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'administratorName' should be defined with a 'pattern' restriction. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L37 |
ResourceNameRestriction |
The resource name parameter 'administratorName' should be defined with a 'pattern' restriction. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L37 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38 |
LroLocationHeader |
A 202 response should include an Location response header. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L88 |
LroLocationHeader |
A 202 response should include an Location response header. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L88 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L100 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L100 |
LroLocationHeader |
A 202 response should include an Location response header. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L132 |
LroLocationHeader |
A 202 response should include an Location response header. Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L132 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Backups/stable/2023-12-30/Backups.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Backups/stable/2023-12-30/Backups.json#L38 |
ResourceNameRestriction |
The resource name parameter 'configurationName' should be defined with a 'pattern' restriction. Location: Configurations/stable/2023-12-30/Configurations.json#L37 |
ResourceNameRestriction |
The resource name parameter 'configurationName' should be defined with a 'pattern' restriction. Location: Configurations/stable/2023-12-30/Configurations.json#L37 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Configurations/stable/2023-12-30/Configurations.json#L38 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Configurations/stable/2023-12-30/Configurations.json#L137 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Configurations/stable/2023-12-30/Configurations.json#L137 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Configurations/stable/2023-12-30/Configurations.json#L143 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Configurations/stable/2023-12-30/Configurations.json#L143 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Configurations/stable/2023-12-30/Configurations.json#L241 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Configurations/stable/2023-12-30/Configurations.json#L241 |
️❌
Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
MULTIPLE_DEFAULT_TAGS |
The readme file has more than one default tag. readme: specification/mysql/resource-manager/readme.md |
The default tag contains multiple API versions swaggers. readme: specification/mysql/resource-manager/readme.md tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Acovado issue is not brought by this PR, we support both flexible and single server. So we need multiple tag for our production. |
/azp run |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Pull request contains merge conflicts. |
We answer all the question in this pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/18167 |
You need to add a suppresion.yaml file for the TypeSpec Requirement check - https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-suppressions#suppressionsyaml |
@xiaoxuqi-ms - You need to add the suppression before requesting merge per this comment: #29031 (comment). Required checks must pass before merge (suppression will allow the Typespec check to pass). |
@mentat9 , I add suppression.yaml but still get stuck in TypeSpec Requirement, could you help to take a look? How can i mitigate this error? |
@xiaoxuqi-ms - Post a question on this to the TypeSpec Discussion channel: https://teams.microsoft.com/l/channel/19%3A906c1efbbec54dc8949ac736633e6bdf%40thread.skype/TypeSpec%20Discussion?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId= and/or the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3A0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%20Spec%20Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. This may be due to a change to Typespec that requires a workaround, but I don't have the details. |
@mentat9 we address the TypeSpec check, could you help to merge this pr? Many thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to merge
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.