Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new GA version: 2023-12-30 for Microsoft.DBForMySQL #29031

Merged
merged 16 commits into from
Jun 24, 2024
Merged

Conversation

xiaoxuqi-ms
Copy link
Member

@xiaoxuqi-ms xiaoxuqi-ms commented May 8, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 8, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 8, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.9) new version base version
AzureADAdministrator.json 2023-12-30(52b1a2d) 2023-06-30(main)
AzureADAdministrator.json 2023-12-30(52b1a2d) 2023-06-01-preview(main)
BackupAndExport.json 2023-12-30(52b1a2d) 2023-06-30(main)
BackupAndExport.json 2023-12-30(52b1a2d) 2023-10-01-preview(main)
Backups.json 2023-12-30(52b1a2d) 2023-06-30(main)
Backups.json 2023-12-30(52b1a2d) 2023-10-01-preview(main)
LongRunningBackups.json 2023-12-30(52b1a2d) 2023-10-01-preview(main)
Configurations.json 2023-12-30(52b1a2d) 2023-06-30(main)
Configurations.json 2023-12-30(52b1a2d) 2023-06-01-preview(main)
Databases.json 2023-12-30(52b1a2d) 2023-06-30(main)
Databases.json 2023-12-30(52b1a2d) 2023-06-01-preview(main)
FirewallRules.json 2023-12-30(52b1a2d) 2023-06-30(main)
FirewallRules.json 2023-12-30(52b1a2d) 2023-06-01-preview(main)
LogFiles.json 2023-12-30(52b1a2d) 2023-06-30(main)
LogFiles.json 2023-12-30(52b1a2d) 2023-06-01-preview(main)
Maintenances.json 2023-12-30(52b1a2d) 2023-10-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-flexibleserver-2024-02-01-preview package-flexibleserver-2024-02-01-preview(52b1a2d) package-flexibleserver-2024-02-01-preview(main)
package-flexibleserver-2024-01-01 package-flexibleserver-2024-01-01(52b1a2d) default(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'administratorName' should be defined with a 'pattern' restriction.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L37
ResourceNameRestriction The resource name parameter 'administratorName' should be defined with a 'pattern' restriction.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L37
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L38
LroLocationHeader A 202 response should include an Location response header.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L88
LroLocationHeader A 202 response should include an Location response header.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L88
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L100
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L100
LroLocationHeader A 202 response should include an Location response header.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L132
LroLocationHeader A 202 response should include an Location response header.
Location: AAD/stable/2023-12-30/AzureADAdministrator.json#L132
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Backups/stable/2023-12-30/Backups.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Backups/stable/2023-12-30/Backups.json#L38
ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Configurations/stable/2023-12-30/Configurations.json#L37
ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: Configurations/stable/2023-12-30/Configurations.json#L37
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Configurations/stable/2023-12-30/Configurations.json#L38
ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
Location: Configurations/stable/2023-12-30/Configurations.json#L137
ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
Location: Configurations/stable/2023-12-30/Configurations.json#L137
LroLocationHeader A 202 response should include an Location response header.
Location: Configurations/stable/2023-12-30/Configurations.json#L143
LroLocationHeader A 202 response should include an Location response header.
Location: Configurations/stable/2023-12-30/Configurations.json#L143
LroLocationHeader A 202 response should include an Location response header.
Location: Configurations/stable/2023-12-30/Configurations.json#L241
LroLocationHeader A 202 response should include an Location response header.
Location: Configurations/stable/2023-12-30/Configurations.json#L241
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule Message
MULTIPLE_DEFAULT_TAGS The readme file has more than one default tag.
readme: specification/mysql/resource-manager/readme.md
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/mysql/resource-manager/readme.md
tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 8, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-net-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 3122c70. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ️✔️Azure.ResourceManager.MySql [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 3122c70. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-rdbms [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 3122c70. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-mysqlflexibleserver [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 3122c70. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/mysql/armmysql [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/mysql/armmysqlflexibleservers [Preview SDK Changes] Breaking Change Detected
    Only showing 60 items here. Refer to log for details.
    info	[Changelog] - New struct `AdvancedThreatProtectionProperties`
    info	[Changelog] - New struct `AdvancedThreatProtectionUpdateProperties`
    info	[Changelog] - New struct `AzureADAdministrator`
    info	[Changelog] - New struct `BackupAndExportRequest`
    info	[Changelog] - New struct `BackupAndExportResponse`
    info	[Changelog] - New struct `BackupAndExportResponseProperties`
    info	[Changelog] - New struct `BackupAndExportResponseType`
    info	[Changelog] - New struct `BackupRequestBase`
    info	[Changelog] - New struct `BackupSettings`
    info	[Changelog] - New struct `Capability`
    info	[Changelog] - New struct `CapabilityPropertiesV2`
    info	[Changelog] - New struct `CapabilitySetsList`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `FullBackupStoreDetails`
    info	[Changelog] - New struct `HighAvailabilityValidationEstimation`
    info	[Changelog] - New struct `ImportFromStorageResponseType`
    info	[Changelog] - New struct `ImportSourceProperties`
    info	[Changelog] - New struct `LogFile`
    info	[Changelog] - New struct `LogFileListResult`
    info	[Changelog] - New struct `LogFileProperties`
    info	[Changelog] - New struct `Maintenance`
    info	[Changelog] - New struct `MaintenanceListResult`
    info	[Changelog] - New struct `MaintenanceProperties`
    info	[Changelog] - New struct `MaintenancePropertiesForUpdate`
    info	[Changelog] - New struct `MaintenanceUpdate`
    info	[Changelog] - New struct `MySQLServerIdentity`
    info	[Changelog] - New struct `MySQLServerSKU`
    info	[Changelog] - New struct `OperationProgressResult`
    info	[Changelog] - New struct `OperationStatusExtendedResult`
    info	[Changelog] - New struct `OperationStatusResult`
    info	[Changelog] - New struct `PrivateEndpoint`
    info	[Changelog] - New struct `PrivateEndpointConnection`
    info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
    info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
    info	[Changelog] - New struct `Provisioning`
    info	[Changelog] - New struct `ProvisioningStateProperties`
    info	[Changelog] - New struct `SKUCapabilityV2`
    info	[Changelog] - New struct `ServerBackupPropertiesV2`
    info	[Changelog] - New struct `ServerBackupV2`
    info	[Changelog] - New struct `ServerBackupV2ListResult`
    info	[Changelog] - New struct `ServerEditionCapabilityV2`
    info	[Changelog] - New struct `ServerGtidSetParameter`
    info	[Changelog] - New struct `ServerVersionCapabilityV2`
    info	[Changelog] - New struct `ValidateBackupResponse`
    info	[Changelog] - New struct `ValidateBackupResponseProperties`
    info	[Changelog] - New field `BackupIntervalHours` in struct `Backup`
    info	[Changelog] - New field `ResetAllToDefault` in struct `ConfigurationListForBatchUpdate`
    info	[Changelog] - New field `CurrentValue`, `DocumentationLink` in struct `ConfigurationProperties`
    info	[Changelog] - New field `Keyword`, `Page`, `PageSize`, `Tags` in struct `ConfigurationsClientListByServerOptions`
    info	[Changelog] - New field `Error` in struct `ErrorResponse`
    info	[Changelog] - New field `SystemData` in struct `ProxyResource`
    info	[Changelog] - New field `SystemData` in struct `Resource`
    info	[Changelog] - New field `ImportSourceProperties`, `PrivateEndpointConnections` in struct `ServerProperties`
    info	[Changelog] - New field `Network`, `Version` in struct `ServerPropertiesForUpdate`
    info	[Changelog] - New field `AutoIoScaling`, `LogOnDisk` in struct `Storage`
    info	[Changelog] - New field `MaxBackupIntervalHours`, `MinBackupIntervalHours` in struct `StorageEditionCapability`
    info	[Changelog] - New field `SystemData` in struct `TrackedResource`
    info	[Changelog] - New field `Location`, `SubscriptionID` in struct `VirtualNetworkSubnetUsageResult`
    info	[Changelog]
    info	[Changelog] Total 8 breaking change(s), 243 additive change(s).
    Present SDK breaking changes suppressions
    Enum `SKUTier` has been removed
    Field `AdditionalInfo`, `Code`, `Details`, `Message`, `Target` of struct `ErrorResponse` has been removed
    Struct `Identity` has been removed
    Struct `SKU` has been removed
    Type of `Server.Identity` has been changed from `*Identity` to `*MySQLServerIdentity`
    Type of `Server.SKU` has been changed from `*SKU` to `*MySQLServerSKU`
    Type of `ServerForUpdate.Identity` has been changed from `*Identity` to `*MySQLServerIdentity`
    Type of `ServerForUpdate.SKU` has been changed from `*SKU` to `*MySQLServerSKU`
    Please refer to the guidance for suppressing SDK breaking changes.
️⚠️ azure-sdk-for-js warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 3122c70. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	Warning: No file changes detected after the generation. Please refer to the generation errors to understand the reasons.
    warn	Warning: No package detected after generation. Please refer to the above logs to understand why the package hasn't been generated.
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 3122c70. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 3122c70. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.mysql.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 8, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/mysql/armmysql There is no API change compared with the previous version
Go sdk/resourcemanager/mysql/armmysqlflexibleservers There is no API change compared with the previous version
Java azure-resourcemanager-mysqlflexibleserver https://apiview.dev/Assemblies/Review/8dd7313daf5c47d38f304b7fbef01335?revisionId=5c4852be76ab4e1abb4f678502f7a0d7
Swagger Microsoft.DBforMySQL https://apiview.dev/Assemblies/Review/0e6b5a22d4bd461b959309d41fc1634e?revisionId=ba08f3c054eb493e8b0c9673ef92837f

@xiaoxuqi-ms
Copy link
Member Author

Acovado issue is not brought by this PR, we support both flexible and single server. So we need multiple tag for our production.

@razvanbadea-msft
Copy link
Contributor

/azp run

Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Copy link

Pull request contains merge conflicts.

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 23, 2024
@xiaoxuqi-ms xiaoxuqi-ms removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 10, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2024
@xiaoxuqi-ms
Copy link
Member Author

We answer all the question in this pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/18167

@razvanbadea-msft
Copy link
Contributor

Hi @razvanbadea-msft our service is brownfield, and currently, we are not required to provide TypeSpec. Could you please help to approve our pr? Many thanks

You need to add a suppresion.yaml file for the TypeSpec Requirement check - https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-suppressions#suppressionsyaml

@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 19, 2024
@xiaoxuqi-ms xiaoxuqi-ms added the MergeRequested Part of the ARM PR review workflow label Jun 20, 2024
@mentat9
Copy link
Member

mentat9 commented Jun 20, 2024

@xiaoxuqi-ms - You need to add the suppression before requesting merge per this comment: #29031 (comment). Required checks must pass before merge (suppression will allow the Typespec check to pass).

@mentat9 mentat9 removed the MergeRequested Part of the ARM PR review workflow label Jun 20, 2024
@xiaoxuqi-ms
Copy link
Member Author

@mentat9 , I add suppression.yaml but still get stuck in TypeSpec Requirement, could you help to take a look? How can i mitigate this error?

@xiaoxuqi-ms xiaoxuqi-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2024
@mentat9
Copy link
Member

mentat9 commented Jun 21, 2024

@mentat9 , I add suppression.yaml but still get stuck in TypeSpec Requirement, could you help to take a look? How can i mitigate this error?

@xiaoxuqi-ms - Post a question on this to the TypeSpec Discussion channel: https://teams.microsoft.com/l/channel/19%3A906c1efbbec54dc8949ac736633e6bdf%40thread.skype/TypeSpec%20Discussion?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=

and/or the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3A0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%20Spec%20Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47.

This may be due to a change to Typespec that requires a workaround, but I don't have the details.

@mentat9 mentat9 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2024
@xiaoxuqi-ms xiaoxuqi-ms added the MergeRequested Part of the ARM PR review workflow label Jun 24, 2024
@xiaoxuqi-ms
Copy link
Member Author

@mentat9 we address the TypeSpec check, could you help to merge this pr? Many thanks

Copy link
Contributor

@ramoka178 ramoka178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to merge

@ramoka178 ramoka178 merged commit 14e15e4 into main Jun 24, 2024
29 of 32 checks passed
@ramoka178 ramoka178 deleted the mysql/20231230 branch June 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved MergeRequested Part of the ARM PR review workflow resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants