-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDInsight on AKS] Az support on Cluster and ClusterPool #29081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
hdinsight.json | 2024-05-01(e5e1450) | 2024-05-01(main) |
Rule | Message |
---|---|
1041 - AddedPropertyInResponse |
The new version has a new property 'availabilityZones' in response that was not found in the old version. New: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3438:7 Old: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3428:7 |
1045 - AddedOptionalProperty |
The new version has a new optional property 'availabilityZones' that was not found in the old version. New: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3438:7 Old: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3428:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-2024-05 | package-2024-05(e5e1450) | package-2024-05(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
XmsPageableForListCalls |
x-ms-pageable extension must be specified for LIST APIs.Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1276 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2136 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2160 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2182 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2318 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2350 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2364 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420 |
AllTrackedResourcesMustHaveDelete |
The resource Cluster does not have a corresponding delete operation. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3479 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3504 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3527 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3538 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3613 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3613 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3633 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3633 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3667 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3674 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L4129 |
Consider using x-ms-client-flatten to provide a better end user experience Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3190 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This apiversion is not released to customer. So breaking change is acceptable. |
AzureRestAPISpecReview
added
ARMReview
NotReadyForARMReview
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
RPaaS
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
labels
May 11, 2024
This was referenced May 11, 2024
mikekistler
added
the
Versioning-Approved-BranchPolicyException
Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep
label
May 15, 2024
AzureRestAPISpecReview
added
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
and removed
NotReadyForARMReview
labels
May 15, 2024
dw511214992
added
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
and removed
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
May 16, 2024
mentat9
added
the
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
label
May 17, 2024
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
May 17, 2024
/pr RequestMerge |
microsoft-github-policy-service
bot
added
the
MergeRequested
Part of the ARM PR review workflow
label
May 21, 2024
razvanbadea-msft
approved these changes
May 21, 2024
Francisco-Gamino
pushed a commit
to Francisco-Gamino/azure-rest-api-specs
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Kai Li <kaili1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Go-Sdk
BreakingChange-Go-Sdk-Approved
MergeRequested
Part of the ARM PR review workflow
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
RPaaS
Versioning-Approved-BranchPolicyException
Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.