Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HDInsight on AKS] Az support on Cluster and ClusterPool #29081

Merged
merged 2 commits into from
May 21, 2024

Conversation

lk668
Copy link
Contributor

@lk668 lk668 commented May 11, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 11, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 11, 2024

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
hdinsight.json 2024-05-01(e5e1450) 2024-05-01(main)
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'availabilityZones' in response that was not found in the old version.
New: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3438:7
Old: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3428:7
1045 - AddedOptionalProperty The new version has a new optional property 'availabilityZones' that was not found in the old version.
New: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3438:7
Old: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3428:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-05 package-2024-05(e5e1450) package-2024-05(main)

The following errors/warnings exist before current PR submission:

Rule Message
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1276
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L1860
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2136
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2160
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2182
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2318
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2350
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L2364
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3420
AllTrackedResourcesMustHaveDelete The resource Cluster does not have a corresponding delete operation.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3479
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3483
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3504
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3527
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3538
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3613
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3613
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3633
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3633
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3667
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3674
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L4129
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: HDInsightOnAks/stable/2024-05-01/hdinsight.json#L3190
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 11, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Pipeline Framework Failed in generating from c1aa8ef. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-Content: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:388
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  388 |        (Get-Content $file) -replace $rquirefileRex, "$requirefile" | S …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |         ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/hdinsight/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers/src/autorest.md' because it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Resolve-Path: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:392
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  392 |      $relativeFolderPath = Resolve-Path $projectFolder -Relative
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/hdinsight/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' because it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
    warn	No file changes detected after generation
    fatal: 'sdkAuto/29081/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch name
  • Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers
    error	Fatal error: fatal: 'sdkAuto/29081/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch name
    error	Fatal error: Error: fatal: 'sdkAuto/29081/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch name    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1445:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1494:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1921:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1919:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:1903:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/simple-git@3.24.0/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    error	The following packages are still pending:
    error		Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from c1aa8ef. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/hdinsightcontainers/armhdinsightcontainers [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Field `ClusterIdentity` of struct `KafkaProfile` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ClusterAvailableUpgradeTypePatchVersionUpgrade` added to enum type `ClusterAvailableUpgradeType`
    info	[Changelog] - New value `ClusterUpgradeTypePatchVersionUpgrade` added to enum type `ClusterUpgradeType`
    info	[Changelog] - New enum type `Category` with values `CategoryCustom`, `CategoryPredefined`
    info	[Changelog] - New enum type `ClusterPoolUpgradeHistoryType` with values `ClusterPoolUpgradeHistoryTypeAKSPatchUpgrade`, `ClusterPoolUpgradeHistoryTypeNodeOsUpgrade`
    info	[Changelog] - New enum type `ClusterPoolUpgradeHistoryUpgradeResultType` with values `ClusterPoolUpgradeHistoryUpgradeResultTypeFailed`, `ClusterPoolUpgradeHistoryUpgradeResultTypeSucceed`
    info	[Changelog] - New enum type `ClusterUpgradeHistorySeverityType` with values `ClusterUpgradeHistorySeverityTypeCritical`, `ClusterUpgradeHistorySeverityTypeHigh`, `ClusterUpgradeHistorySeverityTypeLow`, `ClusterUpgradeHistorySeverityTypeMedium`
    info	[Changelog] - New enum type `ClusterUpgradeHistoryType` with values `ClusterUpgradeHistoryTypeAKSPatchUpgrade`, `ClusterUpgradeHistoryTypeHotfixUpgrade`, `ClusterUpgradeHistoryTypeHotfixUpgradeRollback`, `ClusterUpgradeHistoryTypePatchVersionUpgrade`, `ClusterUpgradeHistoryTypePatchVersionUpgradeRollback`
    info	[Changelog] - New enum type `ClusterUpgradeHistoryUpgradeResultType` with values `ClusterUpgradeHistoryUpgradeResultTypeFailed`, `ClusterUpgradeHistoryUpgradeResultTypeSucceed`
    info	[Changelog] - New enum type `LibraryManagementAction` with values `LibraryManagementActionInstall`, `LibraryManagementActionUninstall`
    info	[Changelog] - New enum type `ManagedIdentityType` with values `ManagedIdentityTypeCluster`, `ManagedIdentityTypeInternal`, `ManagedIdentityTypeUser`
    info	[Changelog] - New enum type `Status` with values `StatusINSTALLED`, `StatusINSTALLFAILED`, `StatusINSTALLING`, `StatusUNINSTALLFAILED`, `StatusUNINSTALLING`
    info	[Changelog] - New enum type `Type` with values `TypeMaven`, `TypePypi`
    info	[Changelog] - New function `*ClientFactory.NewClusterLibrariesClient() *ClusterLibrariesClient`
    info	[Changelog] - New function `*ClientFactory.NewClusterPoolUpgradeHistoriesClient() *ClusterPoolUpgradeHistoriesClient`
    info	[Changelog] - New function `*ClientFactory.NewClusterUpgradeHistoriesClient() *ClusterUpgradeHistoriesClient`
    info	[Changelog] - New function `*ClusterAksPatchUpgradeHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterAvailableInPlaceUpgradeProperties.GetClusterAvailableInPlaceUpgradeProperties() *ClusterAvailableInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterAvailableInPlaceUpgradeProperties.GetClusterAvailableUpgradeProperties() *ClusterAvailableUpgradeProperties`
    info	[Changelog] - New function `*ClusterAvailableUpgradeHotfixUpgradeProperties.GetClusterAvailableInPlaceUpgradeProperties() *ClusterAvailableInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterAvailableUpgradePatchVersionUpgradeProperties.GetClusterAvailableInPlaceUpgradeProperties() *ClusterAvailableInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterAvailableUpgradePatchVersionUpgradeProperties.GetClusterAvailableUpgradeProperties() *ClusterAvailableUpgradeProperties`
    info	[Changelog] - New function `*ClusterHotfixUpgradeHistoryProperties.GetClusterInPlaceUpgradeHistoryProperties() *ClusterInPlaceUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterHotfixUpgradeHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterHotfixUpgradeProperties.GetClusterInPlaceUpgradeProperties() *ClusterInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterHotfixUpgradeRollbackHistoryProperties.GetClusterInPlaceUpgradeHistoryProperties() *ClusterInPlaceUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterHotfixUpgradeRollbackHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterInPlaceUpgradeHistoryProperties.GetClusterInPlaceUpgradeHistoryProperties() *ClusterInPlaceUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterInPlaceUpgradeHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterInPlaceUpgradeProperties.GetClusterInPlaceUpgradeProperties() *ClusterInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterInPlaceUpgradeProperties.GetClusterUpgradeProperties() *ClusterUpgradeProperties`
    info	[Changelog] - New function `NewClusterLibrariesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ClusterLibrariesClient, error)`
    info	[Changelog] - New function `*ClusterLibrariesClient.NewListPager(string, string, string, Category, *ClusterLibrariesClientListOptions) *runtime.Pager[ClusterLibrariesClientListResponse]`
    info	[Changelog] - New function `*ClusterLibrariesClient.BeginManageLibraries(context.Context, string, string, string, ClusterLibraryManagementOperation, *ClusterLibrariesClientBeginManageLibrariesOptions) (*runtime.Poller[ClusterLibrariesClientManageLibrariesResponse], error)`
    info	[Changelog] - New function `*ClusterLibraryProperties.GetClusterLibraryProperties() *ClusterLibraryProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeHistoryProperties.GetClusterInPlaceUpgradeHistoryProperties() *ClusterInPlaceUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeProperties.GetClusterInPlaceUpgradeProperties() *ClusterInPlaceUpgradeProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeProperties.GetClusterUpgradeProperties() *ClusterUpgradeProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeRollbackHistoryProperties.GetClusterInPlaceUpgradeHistoryProperties() *ClusterInPlaceUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterPatchVersionUpgradeRollbackHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterPoolAksPatchUpgradeHistoryProperties.GetClusterPoolUpgradeHistoryProperties() *ClusterPoolUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClusterPoolNodeOsUpgradeHistoryProperties.GetClusterPoolUpgradeHistoryProperties() *ClusterPoolUpgradeHistoryProperties`
    info	[Changelog] - New function `NewClusterPoolUpgradeHistoriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ClusterPoolUpgradeHistoriesClient, error)`
    info	[Changelog] - New function `*ClusterPoolUpgradeHistoriesClient.NewListPager(string, string, *ClusterPoolUpgradeHistoriesClientListOptions) *runtime.Pager[ClusterPoolUpgradeHistoriesClientListResponse]`
    info	[Changelog] - New function `*ClusterPoolUpgradeHistoryProperties.GetClusterPoolUpgradeHistoryProperties() *ClusterPoolUpgradeHistoryProperties`
    info	[Changelog] - New function `NewClusterUpgradeHistoriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ClusterUpgradeHistoriesClient, error)`
    info	[Changelog] - New function `*ClusterUpgradeHistoriesClient.NewListPager(string, string, string, *ClusterUpgradeHistoriesClientListOptions) *runtime.Pager[ClusterUpgradeHistoriesClientListResponse]`
    info	[Changelog] - New function `*ClusterUpgradeHistoryProperties.GetClusterUpgradeHistoryProperties() *ClusterUpgradeHistoryProperties`
    info	[Changelog] - New function `*ClustersClient.BeginUpgradeManualRollback(context.Context, string, string, string, ClusterUpgradeRollback, *ClustersClientBeginUpgradeManualRollbackOptions) (*runtime.Poller[ClustersClientUpgradeManualRollbackResponse], error)`
    info	[Changelog] - New function `*MavenLibraryProperties.GetClusterLibraryProperties() *ClusterLibraryProperties`
    info	[Changelog] - New function `*PyPiLibraryProperties.GetClusterLibraryProperties() *ClusterLibraryProperties`
    info	[Changelog] - New struct `ClusterAksPatchUpgradeHistoryProperties`
    info	[Changelog] - New struct `ClusterAvailableUpgradePatchVersionUpgradeProperties`
    info	[Changelog] - New struct `ClusterHotfixUpgradeHistoryProperties`
    info	[Changelog] - New struct `ClusterHotfixUpgradeRollbackHistoryProperties`
    info	[Changelog] - New struct `ClusterLibrary`
    info	[Changelog] - New struct `ClusterLibraryList`
    info	[Changelog] - New struct `ClusterLibraryManagementOperation`
    info	[Changelog] - New struct `ClusterLibraryManagementOperationProperties`
    info	[Changelog] - New struct `ClusterPatchVersionUpgradeHistoryProperties`
    info	[Changelog] - New struct `ClusterPatchVersionUpgradeProperties`
    info	[Changelog] - New struct `ClusterPatchVersionUpgradeRollbackHistoryProperties`
    info	[Changelog] - New struct `ClusterPoolAksPatchUpgradeHistoryProperties`
    info	[Changelog] - New struct `ClusterPoolNodeOsUpgradeHistoryProperties`
    info	[Changelog] - New struct `ClusterPoolUpgradeHistory`
    info	[Changelog] - New struct `ClusterPoolUpgradeHistoryListResult`
    info	[Changelog] - New struct `ClusterUpgradeHistory`
    info	[Changelog] - New struct `ClusterUpgradeHistoryListResult`
    info	[Changelog] - New struct `ClusterUpgradeRollback`
    info	[Changelog] - New struct `ClusterUpgradeRollbackProperties`
    info	[Changelog] - New struct `ManagedIdentityProfile`
    info	[Changelog] - New struct `ManagedIdentitySpec`
    info	[Changelog] - New struct `MavenLibraryProperties`
    info	[Changelog] - New struct `PyPiLibraryProperties`
    info	[Changelog] - New field `AvailabilityZones` in struct `ClusterPoolResourcePropertiesComputeProfile`
    info	[Changelog] - New field `ManagedIdentityProfile` in struct `ClusterProfile`
    info	[Changelog] - New field `AvailabilityZones` in struct `ComputeProfile`
    info	[Changelog] - New field `VMSize` in struct `SSHProfile`
    info	[Changelog] - New field `SecretsProfile`, `TrinoProfile` in struct `UpdatableClusterProfile`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 137 additive change(s).
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Field `ClusterIdentity` of struct `KafkaProfile` has been removed
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from c1aa8ef. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-hdinsight-containers [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-hdinsight-containers-1.0.0-beta.3-sources.jar
    • azure-resourcemanager-hdinsight-containers-1.0.0-beta.3.jar
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from c1aa8ef. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] E: Failed to fetch http://ppa.launchpad.net/deadsnakes/ppa/ubuntu/pool/main/p/python3.10/python3.10-distutils_3.10.14-1+focal1_all.deb  Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1::81). - connect (101: Network is unreachable)
    cmderr	[automation_init.sh] E: Failed to fetch http://ppa.launchpad.net/deadsnakes/ppa/ubuntu/pool/main/p/python3.10/python3.10-venv_3.10.14-1+focal1_amd64.deb  Cannot initiate the connection to ppa.launchpad.net:80 (2620:2d:4000:1::81). - connect (101: Network is unreachable)
    cmderr	[automation_init.sh] E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[automation_init.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-hdinsightcontainers [Preview SDK Changes]
    • azure_mgmt_hdinsightcontainers-1.0.0b1-py3-none-any.whl
    • azure-mgmt-hdinsightcontainers-1.0.0b1.zip
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from c1aa8ef. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-hdinsightcontainers [Preview SDK Changes]
    • azure-arm-hdinsightcontainers-1.0.0.tgz
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from c1aa8ef. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.7.0` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from c1aa8ef. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.hdinsight.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@dw511214992
Copy link
Member

This apiversion is not released to customer. So breaking change is acceptable.

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 15, 2024
@dw511214992 dw511214992 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 16, 2024
@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 17, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2024
@lk668
Copy link
Contributor Author

lk668 commented May 21, 2024

/pr RequestMerge

@microsoft-github-policy-service microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label May 21, 2024
@razvanbadea-msft razvanbadea-msft merged commit f517936 into Azure:main May 21, 2024
29 of 32 checks passed
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved MergeRequested Part of the ARM PR review workflow ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS Versioning-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants