Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UAMI auth for Data Factory Sql Server connector #29205

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

seanwang051
Copy link
Contributor

@seanwang051 seanwang051 commented May 22, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 22, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

Hi @seanwang051, this service has enabled ShiftLeft Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it is intentional or reject it if it is not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to ShiftLeft Toolset Introduction for details.
  • Please contact service focal contacts or ShiftLeft Toolset Support Channel if need further help.
  • Copy link

    openapi-pipeline-app bot commented May 22, 2024

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Compared specs (v0.10.9) new version base version
    LinkedService.json 2018-06-01(f37d420) 2018-06-01(main)
    LinkedService.json 2020-12-01(f37d420) 2020-12-01(main)
    Rule Message
    1020 - AddedEnumValue The new version is adding enum value(s) 'UserAssignedManagedIdentity' from the old version.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L456:9
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L456:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'UserAssignedManagedIdentity' from the old version.
    New: stable/2020-12-01/entityTypes/LinkedService.json#L408:9
    Old: stable/2020-12-01/entityTypes/LinkedService.json#L408:9
    1045 - AddedOptionalProperty The new version has a new optional property 'credential' that was not found in the old version.
    New: stable/2018-06-01/entityTypes/LinkedService.json#L450:7
    Old: stable/2018-06-01/entityTypes/LinkedService.json#L450:7
    1045 - AddedOptionalProperty The new version has a new optional property 'credential' that was not found in the old version.
    New: stable/2020-12-01/entityTypes/LinkedService.json#L403:7
    Old: stable/2020-12-01/entityTypes/LinkedService.json#L403:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Copy link

    openapi-pipeline-app bot commented May 22, 2024

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️ azure-sdk-for-net-track2 warning [Detail]
    • ⚠️Warning in generating from 765ea99. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
      cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
      cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
      cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
    • ️✔️Azure.ResourceManager.DataFactory [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning in generating from 765ea99. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[automation_init.sh] npm notice
      cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
      cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
      cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
      cmderr	[automation_init.sh] npm notice
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-datafactory [Preview SDK Changes]
      • azure-mgmt-datafactory-1.0.0.zip
      • azure_mgmt_datafactory-1.0.0-py3-none-any.whl
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model ExecuteDataFlowActivity has a new parameter continuation_settings
      info	[Changelog]   - Model ExecuteDataFlowActivityTypeProperties has a new parameter continuation_settings
      info	[Changelog]   - Model ExecutePowerQueryActivityTypeProperties has a new parameter continuation_settings
      info	[Changelog]   - Model ExecuteWranglingDataflowActivity has a new parameter continuation_settings
      info	[Changelog]   - Model SqlServerLinkedService has a new parameter credential
      info	[Changelog]   - Model SqlServerLinkedServiceTypeProperties has a new parameter credential
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 765ea99. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-datafactory [Preview SDK Changes]
      • pom.xml
      • azure-resourcemanager-datafactory-1.0.0-beta.29-sources.jar
      • azure-resourcemanager-datafactory-1.0.0-beta.29.jar
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 765ea99. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-sdk-for-go not found in swagger-to-sdk
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datafactory/armdatafactory [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `SQLServerAuthenticationTypeUserAssignedManagedIdentity` added to enum type `SQLServerAuthenticationType`
      info	[Changelog] - New struct `ContinuationSettingsReference`
      info	[Changelog] - New field `ContinuationSettings` in struct `ExecuteDataFlowActivityTypeProperties`
      info	[Changelog] - New field `ContinuationSettings` in struct `ExecutePowerQueryActivityTypeProperties`
      info	[Changelog] - New field `Credential` in struct `SQLServerLinkedServiceTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded in generating from 765ea99. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-datafactory [Preview SDK Changes] Breaking Change Detected
      • azure-arm-datafactory-16.0.0.tgz
      Only showing 120 items here. Refer to log for details.
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AmazonRdsForSqlServerLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDatabaseLinkedService has a new optional parameter userName
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlDWLinkedService has a new optional parameter userName
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter database
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter server
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter servicePrincipalCredential
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter servicePrincipalCredentialType
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Interface AzureSqlMILinkedService has a new optional parameter userName
      info	[Changelog]   - Interface DynamicsCrmLinkedService has a new optional parameter credential
      info	[Changelog]   - Interface ExecuteDataFlowActivity has a new optional parameter continuationSettings
      info	[Changelog]   - Interface ExecuteDataFlowActivityTypeProperties has a new optional parameter continuationSettings
      info	[Changelog]   - Interface ExecuteWranglingDataflowActivity has a new optional parameter continuationSettings
      info	[Changelog]   - Interface ExpressionV2 has a new optional parameter operators
      info	[Changelog]   - Interface LakeHouseTableDataset has a new optional parameter schemaTypePropertiesSchema
      info	[Changelog]   - Interface ManagedIdentityCredential has a new optional parameter resourceId
      info	[Changelog]   - Interface SalesforceServiceCloudV2Source has a new optional parameter query
      info	[Changelog]   - Interface SalesforceV2Source has a new optional parameter query
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter applicationIntent
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter authenticationType
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter commandTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectRetryCount
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectRetryInterval
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter connectTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter credential
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter database
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter encrypt
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter failoverPartner
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter hostNameInCertificate
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter integratedSecurity
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter loadBalanceTimeout
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter maxPoolSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter minPoolSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter multipleActiveResultSets
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter multiSubnetFailover
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter packetSize
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter pooling
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter server
      info	[Changelog]   - Interface SqlServerLinkedService has a new optional parameter trustServerCertificate
      info	[Changelog]   - Type of parameter type of interface Credential_2 is changed from "ManagedIdentity" | "ServicePrincipal" to "ServicePrincipal" | "ManagedIdentity"
      info	[Changelog]   - Added Enum KnownAmazonRdsForSqlAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlDatabaseAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlDWAuthenticationType
      info	[Changelog]   - Added Enum KnownAzureSqlMIAuthenticationType
      info	[Changelog]   - Added Enum KnownSqlServerAuthenticationType
      info	[Changelog]   - Enum KnownExpressionV2Type has a new value NAry
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ExpressionV2 no longer has parameter operator
      info	[Changelog]   - Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      Present SDK breaking changes suppressions
      Interface ExpressionV2 no longer has parameter operator
      Interface ManagedIdentityCredential no longer has parameter resourceId
      Operation CredentialOperations.createOrUpdate has a new signature
      Type of parameter headers of interface AzureFunctionActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter headers of interface WebHookActivity is changed from {        [propertyName: string]: string;    } to {        [propertyName: string]: any;    }
      Type of parameter type of interface ScriptActivityScriptBlock is changed from ScriptType to any
      Type of parameter value of interface CredentialListResponse is changed from ManagedIdentityCredentialResource[] to CredentialResource[]
      Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Code Generator Failed in generating from 765ea99. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
      cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
      cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
      cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
      cmderr	[initScript.sh] npm notice
      cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
      cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
      cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
      cmderr	[initScript.sh] npm notice
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
      cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
      cmderr	[generateScript.sh]            ^
      cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
      cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
      cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
      cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
      cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
      cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
      cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
      cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
      cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
      cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
      cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
      cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
      cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
      cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
      cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
      cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
      warn	Skip package processing as generation is failed
      warn		specification/synapse/data-plane/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk
      error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
    ️⚠️ azure-powershell warning [Detail]
    • ⚠️Warning in generating from 765ea99. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      warn		specification/synapse/data-plane/readme.md skipped due to azure-powershell not found in swagger-to-sdk
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ⚠️Az.datafactory.DefaultTag [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 22, 2024
    @JeffreyRichter JeffreyRichter added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label May 24, 2024
    @AzureRestAPISpecReview AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 28, 2024
    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 8, 2024
    @openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 8, 2024
    @Frey-Wang Frey-Wang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 10, 2024
    @seanwang051
    Copy link
    Contributor Author

    /pr RequestMerge

    @microsoft-github-policy-service microsoft-github-policy-service bot added the MergeRequested Part of the ARM PR review workflow label Jun 10, 2024
    @seanwang051 seanwang051 changed the title Enable SAMI and UAMI auth for Data Factory Sql Server connector Enable UAMI auth for Data Factory Sql Server connector Jun 11, 2024
    @razvanbadea-msft razvanbadea-msft merged commit 99f53b4 into Azure:main Jun 11, 2024
    30 of 32 checks passed
    markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Jun 11, 2024
    * update
    
    * remove SAMI
    
    ---------
    
    Co-authored-by: seanwang051 <xiaojwan@microsoft.com>
    Co-authored-by: Razvan Badea <156206747+razvanbadea-msft@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review customer-reported Issues that are reported by GitHub users external to the Azure organization. data-plane MergeRequested Part of the ARM PR review workflow ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager ShiftLeftViolation Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    6 participants