Release azuredatatransfer microsoft.azure data transfer stable/2024 05 07 #29211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-01-25 to stable/2024-05-07.
…aTransfer-stable/2024-05-07
…table/2024-05-07' of https://github.com/Azure/azure-rest-api-specs into release-azuredatatransfer-Microsoft.AzureDataTransfer-stable/2024-05-07
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.8) | new version | base version |
|---|---|---|
| azuredatatransfer.json | 2024-05-07(59059e8) | 2024-01-25(main) |
| azuredatatransfer.json | 2024-05-07(59059e8) | 2023-10-11-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-05 | package-2024-05(59059e8) | default(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L294 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2020 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2035 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2069 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2073 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2098 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2098 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2098 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2151 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2151 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2151 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2173 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2173 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2173 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2203 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2203 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2203 |
| Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L77 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Performs action request Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L79 |
|
| OperationId should contain the verb: 'listpendingconnections' in:'ListPendingConnections_List'. Consider updating the operationId Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L820 |
|
| OperationId should contain the verb: 'listpendingflows' in:'ListPendingFlows_List'. Consider updating the operationId Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L862 |
|
| OperationId should contain the verb: 'listschemas' in:'ListSchemas_List'. Consider updating the operationId Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L1305 |
|
| Schema should have a description or title. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L1481 |
|
| Use the latest version v5 of managedidentity.json. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L1675 |
|
| Use the latest version v5 of managedidentity.json. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L1717 |
|
Property location must have 'x-ms-mutability':['read', 'create'] extension defined.Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2053 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2069 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2168 |
|
| Schema should have a description or title. Location: Microsoft.AzureDataTransfer/stable/2024-05-07/azuredatatransfer.json#L2218 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
new-api-version
ReadyForApiTest
This was referenced May 22, 2024
| "properties": { | ||
| "storageAccountName": "testsa", | ||
| "storageContainerName": "testcontainer", | ||
| "flowType": "Blob", |
There was a problem hiding this comment.
Updated examples to include valid flow type.
razvanbadea-msft
added
the
ARMChangesRequested
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
razvanbadea-msft
removed
the
ARMChangesRequested
openapi-pipeline-app
bot
added
the
WaitForARMFeedback
|
@johnkoh-msft I removed the label for you so that the PR will go in the reviewing queue of the current oncall reviewer. |
rkmanda
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
microsoft-github-policy-service
bot
added
the
MergeRequested
rkmanda
approved these changes
Jun 11, 2024
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 11, 2024
…5 07 (Azure#29211) * Copy files from stable/2024-01-25 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-05-07 Updated the API version from stable/2024-01-25 to stable/2024-05-07. * Added tag for 2024-05-07 in readme file * Add new flow types * Run prettier * Run prettier for all files * Add schema direction * Add Standard flow type * Replace Blob with Standard in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.