-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAI] Added missing GA service versions, 2024-02-01 and 2024-06-01 #29424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.12) | new version | base version |
---|---|---|
generated.json | 2024-02-01(98cb3b3) | 2024-02-01(main) |
generated.json | 2024-06-01(98cb3b3) | 2024-06-01(main) |
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-02-01/generated.json#L62:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-02-01/generated.json#L114:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-02-01/generated.json#L166:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-02-01/generated.json#L218:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-02-01/generated.json#L271:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L62:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L118:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L291:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L423:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L496:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L548:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L600:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L654:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: inference/stable/2024-06-01/generated.json#L823:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 8 Errors, 80 Warnings failed [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
release_2024_02_01 | release_2024_02_01(98cb3b3) | default(main) |
release_2024_02_01_autogen | release_2024_02_01_autogen(98cb3b3) | default(main) |
release_2024_06_01_autogen | release_2024_06_01_autogen(98cb3b3) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-02-01/generated.json#L427 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-02-01/generated.json#L498 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-02-01/generated.json#L850 |
|
DefaultInEnum |
Default value should appear in the enum constraint for a schema Location: inference/stable/2024-02-01/generated.json#L1390 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-02-01/generated.json#L1454 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-06-01/generated.json#L2345 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-06-01/generated.json#L2988 |
|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: inference/stable/2024-06-01/generated.json#L4066 |
|
Security definition should have a description. Location: inference/stable/2024-02-01/generated.json#L46 |
||
Security definition should have a description. Location: inference/stable/2024-02-01/generated.json#L51 |
||
OperationId should be of the form 'Noun_Verb' Location: inference/stable/2024-02-01/generated.json#L64 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: inference/stable/2024-02-01/generated.json#L70 |
||
OperationId should be of the form 'Noun_Verb' Location: inference/stable/2024-02-01/generated.json#L116 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: inference/stable/2024-02-01/generated.json#L122 |
||
Operation might be pageable. Consider adding the x-ms-pageable extension. Location: inference/stable/2024-02-01/generated.json#L167 |
||
OperationId should be of the form 'Noun_Verb' Location: inference/stable/2024-02-01/generated.json#L168 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: inference/stable/2024-02-01/generated.json#L174 |
||
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: inference/stable/2024-02-01/generated.json#L218 |
RPC-Async-V1-05 | |
OperationId should be of the form 'Noun_Verb' Location: inference/stable/2024-02-01/generated.json#L220 |
||
OperationId should be of the form 'Noun_Verb' Location: inference/stable/2024-02-01/generated.json#L273 |
||
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: inference/stable/2024-02-01/generated.json#L279 |
||
Property should have a defined type. Location: inference/stable/2024-02-01/generated.json#L556 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: inference/stable/2024-02-01/generated.json#L614 |
||
Property should have a defined type. Location: inference/stable/2024-02-01/generated.json#L722 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: inference/stable/2024-02-01/generated.json#L1027 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: inference/stable/2024-02-01/generated.json#L1056 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: inference/stable/2024-02-01/generated.json#L1102 |
||
Property should have a defined type. Location: inference/stable/2024-02-01/generated.json#L1348 |
||
Security definition should have a description. Location: inference/stable/2024-06-01/generated.json#L46 |
||
Security definition should have a description. Location: inference/stable/2024-06-01/generated.json#L51 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
SpellCheck: 14 Errors, 0 Warnings failed [Detail]
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jun 13, 2024
2 tasks
trrwilson
reviewed
Jul 10, 2024
trrwilson
approved these changes
Jul 10, 2024
…st-api-specs into OpenAI-2024-02-01
mssfang
commented
Jul 10, 2024
…st-api-specs into OpenAI-2024-02-01
This pr was merged with typespec build failing… |
zaowang-ms
pushed a commit
to zaowang-ms/azure-rest-api-specs-public
that referenced
this pull request
Jul 22, 2024
…Azure#29424) * added a missing GA service version * add the generated.json 2024-02-01 but looks different to inference.json * add the 2024-06-01 service API version * remove self introudced new generated.json from 2024-02-01 * added operation id * Update specification/ai/Face/tspconfig.yaml * Ran npx tsv command * copied from previous examples * added generated swagger version into readme * fixed "Missing required property: deployment-id" * run tsp compile * generated.json with generated_ prefix json file. * revert the data-plane changes for inference.json * add generated.json updates * suppress spellcheck failures --------- Co-authored-by: Jose Alvarez <jp.alvarezl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data-plane
OpenAI
OpenAI service
TypeSpec
Authored with TypeSpec
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have announced a GA release version,
2024-02-01
, but it is not supported in the latest TypeSpec 's service version list.We have this GA version in the repo.
https://github.com/Azure/azure-rest-api-specs/tree/main/specification/cognitiveservices/data-plane/AzureOpenAI/inference/stable/2024-02-01
Updates (2024/07/10):
We just have
2024-06-01
Service API version supported recently. This PR will add it to the Service API version list as well.