Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove basePath from Computer Vision 2.0 examples. #3479

Merged
merged 1 commit into from Jul 25, 2018
Merged

Remove basePath from Computer Vision 2.0 examples. #3479

merged 1 commit into from Jul 25, 2018

Conversation

yangyuan
Copy link
Member

@yangyuan yangyuan commented Jul 23, 2018

Additional to #3440, fix examples.
Please hold for @cthrash's review.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2018

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2018

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2018

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2018

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

@AutorestCI
Copy link

AutorestCI commented Jul 23, 2018

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

Copy link
Contributor

@cthrash cthrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marstr
Copy link
Member

marstr commented Jul 24, 2018

Ready for me to merge, @yangyuan?

@yangyuan
Copy link
Member Author

@marstr Yes, please merge. :)

@yangyuan yangyuan changed the title Remove basePath from Computer Vision 2.0 swagger. Remove basePath from Computer Vision 2.0 examples. Jul 24, 2018
@marstr marstr merged commit 0840eaa into Azure:master Jul 25, 2018
cthrash added a commit to cthrash/azure-sdk-for-net that referenced this pull request Jul 31, 2018
Updates for [PR1](Azure/azure-rest-api-specs#3479) and [PR2](Azure/azure-rest-api-specs#3486).

* The API client name was changed from ComputerVisionAPI to ComputerVisionClient, in keeping with other Azure SDKs.
* The way the Azure region is specfied has changed.  Specifically, the AzureRegion property was dropped in favor of an Endpoint property.  If you were previously specifying an AzureRegion value, you should now specify Endpoint='https://{AzureRegion}.api.cognitive.microsoft.com' instead. This change ensures better global coverage.
* Some inconsistencies in argument types were corrected.  (a) maxCandidate is an integer for DescribeImage. (b) details is a array of enumerated types for AnalyzeImage. (c) isBWImg in the AnalyzeImage(color) response is a non-nullable bool. (d) clipArtType/lineDrawing in AnalyzeImage(imageType) is an integer (index) instead of a double.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants