Set provisioning state to read only, and fix force update property in 2015-06-15 version #359
Conversation
hyonholee
changed the title
|
@hyonholee - Can you fix the issue mentioned here #352 at the same time? It should be a really simple fix. |
| "name": "ForceUpdateTagTypes", | ||
| "modelAsString": false | ||
| } | ||
| "description": "Gets or sets how the extension handler should be forced to update even if the extension configuration has not changed." |
There was a problem hiding this comment.
The description should just be: "How the extension handler..." The individual language generators will add the Gets or Sets if it's appropriate (some languages don't support properties). Adding Gets or Sets results in this description for C#:
/// Gets or sets gets or sets how the extension handler should be
/// forced to update even if the extension configuration has not
/// changed.
| @@ -243,7 +243,7 @@ | |||
| "VirtualMachineExtensionImages" | |||
| ], | |||
| "operationId": "VirtualMachineExtensionImages_Get", | |||
| "description": "Gets a virtual machine extension image.", | |||
| "description": "a virtual machine extension image.", | |||
| "parameters": [ | |||
There was a problem hiding this comment.
Sorry if I wasn't clear, currently Autorest only appends Gets or Gets and Sets to properties not operation descriptions
|
@lmazuel the Travis CI is now failing with this error: Can you please take a look? |
|
@John-Hart Yes, I answered in the email thread I'm on it :) |
|
Test passed. Can it be merged? Thanks |
| "https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/2016-03-30/swagger/compute.json", | ||
| "https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/2016-03-30/swagger/containerService.json" | ||
| "./arm-compute/2016-03-30/swagger/compute.json", | ||
| "./arm-compute/2016-03-30/swagger/containerService.json" | ||
| ] |
There was a problem hiding this comment.
On this only @devigned can make the final decision. I adapted my script in a feature branch ready to be merged in case of.
Currently testing this branch.
|
LKTM |
|
No modification for NodeJS |
|
No modification for Python |
No description provided.