Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customer error spec for Application Gateway #3985

Merged

Conversation

KaiChiLin
Copy link

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

msftclas commented Sep 21, 2018

CLA assistant check
All CLA requirements met.

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3409

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmprbvjz2ea/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmprbvjz2ea/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.103']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.103->2.1.103)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

@jianghaolu jianghaolu merged commit 26fc76c into Azure:network-october-release Sep 21, 2018
@AutorestCI
Copy link

AutorestCI commented Sep 22, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

lmazuel added a commit that referenced this pull request Oct 30, 2018
* Updated NetworkConfigurationDiagnostic API + example (#3905)

* Fix incorrect API versions in Network's examples (#3954)

* Fixed incorrect API versions in 2018-08-01's examples Added missing example for serviceEndpointPolicy.json

* Fixed incorrect API version in 2018-07-01 example

* swagger change for application gateway waf global config and exclusion list (#3972)

* swagger change for application gateway waf global config and exclusion list

* address the comments

* add customer error spec for Application Gateway (#3985)

* add customer error spec for Application Gateway

* fix property name issue

* Add ICMP to the list of supported protocols (#3993)

* change appgw custom error status code enum and fix a typo of customErrorConfigurations (#4050)

* add customer error spec for Application Gateway

* fix property name issue

* change appgw custom error status code enum and fix a typo of customErrorConfiguration

* Add ExpressRoutePort swagger (#4104)

* Add ExpressRoutePort details to readme.md

* ExpressRoutePort swagger

* Refer SubscriptionIdParameter and ApiVersionParameter from network.json

* Cherry pick NRP's changes from master to October branch (#4251)

* Remove error code from swagger (#4103)

* Modifying example templates : enabling Ipv6 support for Private Peering (#4232)

* Modifying example templates : enabling Ipv6 support for Private Peering

* Resolving oav validation error

* Changes to add operation id for outbound rules (#4320)

* Changes to add operation id for outbound rules

* Changes to make outbound rule similar to load balancing rule

* fix failures - add example json files

* fix failures

* Fixed line endings, specs, examples

* Change one parameter (#4339)

* Change parameter in most recent version

* Fix example

* New SKU for ER (#4342)
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants