Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new type for forecast and usage - preview #4253

Merged
merged 5 commits into from Oct 17, 2018

Conversation

kjeur
Copy link
Contributor

@kjeur kjeur commented Oct 17, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Oct 17, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@jhendrixMSFT
Copy link
Member

It looks like this content was already merged in #4222. Can you please clarify the purpose of this PR?

@kjeur
Copy link
Contributor Author

kjeur commented Oct 17, 2018

@jhendrixMSFT Yes that PR is merged. I am making changes in same swagger.

@jhendrixMSFT
Copy link
Member

I see. You need to merge the upstream changes into your branch and then rebase your pending changes.

@kjeur
Copy link
Contributor Author

kjeur commented Oct 17, 2018

@jhendrixMSFT Ahh.. I didn't see those conflicts.

@jhendrixMSFT jhendrixMSFT merged commit fc9b3f1 into Azure:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants